256 keep run selection constant#271
Merged
Merged
Conversation
When new runs are added to the catalog, the table view's selection was staying on the same row index instead of tracking the selected run by UID. This caused the visual selection to appear on the wrong run after the table data shifted. Changes: - Restore selection in updateModelData() based on selected_run_uid after model updates, ensuring the correct run remains selected even when new runs are added and rows shift - Move selected_run_uid assignment before try/except blocks in doRunSelectedSlot() and doRunDoubleClickSlot() to ensure it's set even when getDataDescription() fails (e.g., for runs without fields yet). This prevents selection from jumping back to the previous run when selecting runs that don't have plottable data yet.
During live plotting updates, refreshFieldData() was rebuilding the field selection table even when fields weren't readable yet (Container objects without .read() method), causing the table to flash empty. Fixed by checking if any fields have readable (non-empty) shapes before rebuilding the table in setStream(); if all fields have empty shapes and an existing table exists, skip the rebuild to prevent the flash. Also changed log level from WARNING to DEBUG for Container objects without .read() method.
Prevents traceback flood when tiled server connection fails after stamina retries.
The selected_run_uid is already set before the try/except block (line 295), so the duplicate assignment after setStatus() (line 306) was redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close Keep run selection constant when new runs are added to catalog #256
updateModelData()based on selected_run_uid after model updatesselected_run_uiddefinition before try/except blocks indoRunSelectedSlot()anddoRunDoubleClickSlot()to ensure it's set even when getDataDescription() fails (e.g., for runs without fields yet). This prevents selection from jumping back to the previous run when selecting runs that don't have plottable data yet (active run).close Field selection table flashes empty during live plotting #269
setStream(); if all fields have empty shapes and an existing table exists, skip the rebuild to prevent the flash.close Error when connection is refused #262
httpx.ConnectErrorinstream_dataand log as warning