226 bug indexerror crashes app#261
Merged
Merged
Conversation
Handle dimensions with empty motor lists by using 'time' as fallback axis signal instead of raising IndexError.
- Catch exceptions in stream_data() and force_refresh_stream_data() and log them - Catch exceptions in to_datasets() and get_field_array(), display in status bar and log them
- Calculate page size dynamically based on number of visible whole rows in table - Auto-update page size when table is resized (with debouncing) - Remove combobox setup and signal connections
Contributor
|
I've got problems (#251 (comment)) trying to evaluate against #251. |
Contributor
|
Page sizing works! |
Contributor
|
Confirmed that I can't filter for scan ID 1258 in the ht_hedm catalog. Same Can you reproduce this problem with filtering? You could try the code from my conda env: |
Collaborator
Author
|
I was able to confirm that scan ID 1258 in the ht_hedm catalog works with the fix using a downgraded conda environment (with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
axes = [get_signal(d[0][0]) if len(d[0]) > 0 else "time" for d in run_dims]