[action] [PR:2060] vpp: refresh speed cache after successful update - #140
Merged
Merged
Conversation
### Description of PR Summary: Refreshes the cached operational speed after a successful VPP interface speed update. This prevents operational state from temporarily retaining the previous speed after a runtime speed change. ### Type of change - [x] Bug fix - [ ] New feature - [ ] Refactor / cleanup - [ ] Documentation update - [ ] Test improvement ### Approach #### What is the motivation for this PR? SAI-VPP could return a cached speed immediately after successfully changing an interface speed, causing the reported operational speed to remain stale. ##### Work item tracking - Microsoft ADO **(number only)**: N/A #### How did you do it? - Check the result of the VPP speed-update request. - Return failure if the speed update fails. - Refresh the cached interface speed after a successful update. - Log a warning if the cache refresh fails. #### How did you verify/test it? Verified repeated 1G-to-10G and 10G-to-1G transitions. The configured and operational speed states converged correctly without requiring an additional interface flap. ### Tested Branch and UT logs: Verified the fix on 202603 branch. Test results/UT logs: [arctos_saivpp_speed_cache_refresh_ut_20260825.txt](https://github.com/user-attachments/files/31654725/arctos_saivpp_speed_cache_refresh_ut_20260825.txt) #### Any platform specific information? This change applies to the VPP SAI implementation. ### Documentation No documentation changes are required. Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Collaborator
Author
|
Original PR: sonic-net/sonic-sairedis#2060 |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
Author
|
/azp run |
1 similar comment
Collaborator
Author
|
/azp run |
5 tasks
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
1 similar comment
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Refreshes the cached operational speed after a successful VPP interface speed update. This prevents operational state from temporarily retaining the previous speed after a runtime speed change.
Type of change
Approach
What is the motivation for this PR?
SAI-VPP could return a cached speed immediately after successfully changing an interface speed, causing the reported operational speed to remain stale.
Work item tracking
How did you do it?
How did you verify/test it?
Verified repeated 1G-to-10G and 10G-to-1G transitions. The configured and operational speed states converged correctly without requiring an additional interface flap.
Tested Branch and UT logs:
Verified the fix on 202603 branch.
Test results/UT logs:
arctos_saivpp_speed_cache_refresh_ut_20260825.txt
Any platform specific information?
This change applies to the VPP SAI implementation.
Documentation
No documentation changes are required.
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com