[202608][system_health]: Skip LED check on BMC platforms without system status LED support (#27361) - #1397
Merged
Jianquan Ye (yejianquan) merged 1 commit intoSep 2, 2026
Conversation
…s LED support (#27361)
Summary:
Fixes #27360
`test_service_checker` and `test_service_checker_with_process_exit` fail
on BMC platforms (e.g. `Nokia-7220-Th6p` BMC topology) because BMC
devices do not implement the system status LED chassis APIs. On those
platforms `show system-health summary` exits non-zero
(`chassis.set_status_led is not implemented` / `AttributeError:
'Chassis' object has no attribute 'initizalize_system_led'`), causing
`check_system_health_led_info` to raise `RunAnsibleModuleFail`.
- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
- [ ] Skipped for non-supported platforms
- [ ] Test case improvement
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [ ] 202511
- [x] 202608
BMC devices don't implement the system status LED APIs. The LED check
should be skipped on BMC platforms rather than failing the whole test,
while behavior on all other platforms stays unchanged.
`check_system_health_led_info` now returns early (with a warning) when
`duthost.is_bmc()` is `True`. Non-BMC platforms are unaffected.
Verified the module compiles (`python -m py_compile`). On BMC platforms
the LED check is skipped with a warning; on all other platforms the
existing LED verification runs as before.
Scoped to BMC devices (detected via `DEVICE_METADATA.localhost.type ==
'NetworkBmc'`), e.g. `Nokia-7220-Th6p` BMC topology. No behavior change
for non-BMC platforms.
N/A — existing test cases.
N/A
---------
Signed-off-by: Edi Wibowo <ediwibowo@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit c6ccce55353212066cfab6ff46bd7a899a5b918b)
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
13 tasks
Dashuai Zhang (sdszhang)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27361 to the
202608branch.Resolves the
Cherry Pick Conflict_msft-202608from the automated cherry-pick. The conflict arose because the202608branch has an older version ofcheck_system_health_led_info(without the_fetch_led_and_statusrefactor present on master). Resolved by adding the BMC guard on top of the202608version of the function body.What changed
check_system_health_led_infonow returns early (with a warning) whenduthost.is_bmc()isTrue, sotest_service_checkerandtest_service_checker_with_process_exitskip the LED check on BMC platforms (e.g.Nokia-7220-Th6p) instead of failing. Non-BMC platforms are unaffected.Original PR: #27361