Fixing the semantic of skip_azure_sdk - #364
Open
Joao C Costa (joaocc) wants to merge 1 commit into
Open
Conversation
I believe the previous condition was reversed (ie, it would only run if skip_azure_sdk was set to true, which means it would be run most of the time because the default setting is set to true).
Fred-sun
requested review from
Jie Shen (gavinfish) and
haiyuan_zhang (haiyuazhang)
February 20, 2020 02:56
Collaborator
|
ready_for_review |
Collaborator
Collaborator
|
Joao C Costa (@joaocc) Thank you for taking the time to contribute to this PR. We will transferred ansible 's azure module related Issue and PR to azure collection (https://github.com/ansible-collections/azure/pulls), can you transfer the Issue to azure collection repo? |
Collaborator
|
Joao C Costa (@joaocc) Thank you very much for your interest in Ansible. This repo is no longer maintained in this repository and has been migrated to https://github.com/ansible-collections/azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the previous condition was reversed (ie, it would only run if skip_azure_sdk was set to true, which means it would be run most of the time because the default setting is set to true).