Disable Mac build to unblock CI#5778
Conversation
|
/azp run cpp - attestation, cpp - core, cpp - eventhubs, cpp - identity, cpp - keyvault, cpp - storage, cpp - tables, cpp - template |
|
Azure Pipelines successfully started running 8 pipeline(s). |
gearama
left a comment
There was a problem hiding this comment.
i'm not sure we should do this, while the pipelines are blocked, we shouldn't reduce our coverage just to get it passed, at the end of the day we shoiuld get it fixes, irrelevant of how many things are blocked, merging without validation on mac is risky, several times i got breaks on mac that were not showing up on linux or windows
|
attestation and eventhubs will fail |
|
@gearama , attestation and eventhubs will fail due to auth issues with samples which is fixed in other PR, but wich can't get checked in because of Mac issue? See, this is not a permanent fix. But we need to somehow get unblocked. For example, there is also a PR that would give us better logs for vcpkg, but none can go in at the moment. I'd say, we temporarily drop building on macs in our CI, but our commits get unblocked, and we are able to gather more information, because the root cause is very likely not within our repo. |
|
While the checks are failing you can still override check-enforcer after verifying they are the known issues and then merge the PR still. |
|
Yes, we can merge to main, but we won't be able to release with pipelines failing |
If rick approves that's fine by me, i want another set of eyes on this and to not be forgotten |
|
There will be a proper fix tomorrow. |
No description provided.