Skip to content

Disable Mac build to unblock CI#5778

Closed
antkmsft wants to merge 2 commits into
Azure:mainfrom
antkmsft:disable-macoslatest
Closed

Disable Mac build to unblock CI#5778
antkmsft wants to merge 2 commits into
Azure:mainfrom
antkmsft:disable-macoslatest

Conversation

@antkmsft

@antkmsft antkmsft commented Jul 10, 2024

Copy link
Copy Markdown
Member

No description provided.

@antkmsft antkmsft added the EngSys This issue is impacting the engineering system. label Jul 10, 2024
@antkmsft antkmsft self-assigned this Jul 10, 2024
@antkmsft antkmsft changed the title Disable macoslatest to unblock CI Disable Mac build to unblock CI Jul 10, 2024
@antkmsft antkmsft marked this pull request as ready for review July 10, 2024 20:52
@antkmsft

Copy link
Copy Markdown
Member Author

/azp run cpp - attestation, cpp - core, cpp - eventhubs, cpp - identity, cpp - keyvault, cpp - storage, cpp - tables, cpp - template

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 8 pipeline(s).

@gearama gearama left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure we should do this, while the pipelines are blocked, we shouldn't reduce our coverage just to get it passed, at the end of the day we shoiuld get it fixes, irrelevant of how many things are blocked, merging without validation on mac is risky, several times i got breaks on mac that were not showing up on linux or windows

@gearama

gearama commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

attestation and eventhubs will fail

@antkmsft

Copy link
Copy Markdown
Member Author

@gearama , attestation and eventhubs will fail due to auth issues with samples which is fixed in other PR, but wich can't get checked in because of Mac issue?

See, this is not a permanent fix. But we need to somehow get unblocked. For example, there is also a PR that would give us better logs for vcpkg, but none can go in at the moment.

I'd say, we temporarily drop building on macs in our CI, but our commits get unblocked, and we are able to gather more information, because the root cause is very likely not within our repo.
As of releases, we are still covered by microsoft/vcpkg#34835 as build validation for macs.

@antkmsft antkmsft requested review from RickWinter and gearama July 10, 2024 21:45
@weshaggard

Copy link
Copy Markdown
Member

While the checks are failing you can still override check-enforcer after verifying they are the known issues and then merge the PR still.

@antkmsft

Copy link
Copy Markdown
Member Author

Yes, we can merge to main, but we won't be able to release with pipelines failing

@gearama

gearama commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

@gearama , attestation and eventhubs will fail due to auth issues with samples which is fixed in other PR, but wich can't get checked in because of Mac issue?

See, this is not a permanent fix. But we need to somehow get unblocked. For example, there is also a PR that would give us better logs for vcpkg, but none can go in at the moment.

I'd say, we temporarily drop building on macs in our CI, but our commits get unblocked, and we are able to gather more information, because the root cause is very likely not within our repo. As of releases, we are still covered by microsoft/vcpkg#34835 as build validation for macs.

If rick approves that's fine by me, i want another set of eyes on this and to not be forgotten

@antkmsft

Copy link
Copy Markdown
Member Author

There will be a proper fix tomorrow.

@antkmsft antkmsft closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants