Removed storage dependency from eventhubs#4954
Conversation
LarryOsterman
requested review from
RickWinter,
ahsonkhan,
antkmsft,
gearama and
vhvb1989
as code owners
Hooray! 🎉 |
LarryOsterman
force-pushed
the
larryo/removeehstoragedependency
branch
from
7815ee4 to
f0ef8ac
Compare
|
@antkmsft , I would appreciate your looking at the vcpkg directory, since that hasn't been tested. |
antkmsft
left a comment
antkmsft
left a comment
There was a problem hiding this comment.
Other than two comments, the stuff in /vcpkg dir looks good to me. We may see more once this is checked in and runs as part of the vcpkg validation run (microsoft/vcpkg#17119).
I haven't revieved the rest, I'll come back to that later.
There was a problem hiding this comment.
It looks like you are removing the dependency on azure-storage-blobs-cpp from the azure-messaging-eventhubs-cpp.
I don't see the corresponding updates to remove it in the azure-messaging-eventhubs-cpp directory (azure-messaging-eventhubs/vcpkg.json, azure-messaging-eventhubs/vcpkg/*).
They should be there now. |
There was a problem hiding this comment.
You also need to update azure-messaging-eventhubs/CMakeLists.txt to remove the
find_package(azure-storage-blobs-cpp CONFIG QUIET)
if(NOT azure-storage-blobs-cpp_FOUND)
find_package(azure-storage-blobs-cpp REQUIRED)
endif()
and
target_link_libraries(azure-messaging-eventhubs PUBLIC ... Azure::azure-storage-blobs)
And also there's FolderList.cmake file.
antkmsft
left a comment
antkmsft
left a comment
There was a problem hiding this comment.
BTW, if there are there any samples in the non-storageblobs eventhubs that need to be updated or moved to eventhubs-storage-blob, please move or update them.
There are no samples currently that test the processor, which is where the checkpoint store is used. |
… CI builds because EH doesn't depend on otel.
LarryOsterman
requested review from
benbp,
danieljurek and
weshaggard
as code owners
|
/azp run cpp - eventhubs - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run cpp - eventhubs - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 participants
Fixes #4961
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.