Fix eventhubs manifest #4812
Conversation
|
The Go SDK is correct according to the rules of go. The C++ SDK follows the patterns of all the other languages and there is no overarching reason to align the C++ repo with the Go repo instead of the other languages. Putting the EventHubs service in the EventHubs directory was quite intentional and should not be changed without a VERY strong reason, and "compatibility with Go" is not a strong reason, IMHO. And at a minimum, moving the ci.yml file from the EventHubs directory to messaging\eventhubs messes up the name of the pipeline created by the create-pipelines pipeline (instead of the pipeline being cpp - eventhubs - ci, it turns into cpp - messaging-eventhubs - ci, which is different from the other pipelines. The vcpkg manifest should be corrected to reflect the source tree layout instead of the source tree layout being changed to reflect the vcpkg manifest. |
|
@LarryOsterman, I inverted the change, please check it out now. |
vcpkg manifest has it under
/messaging/:azure-sdk-for-cpp/sdk/eventhubs/azure-messaging-eventhubs/vcpkg/portfile.cmake
Line 12 in b54d509
(Currently, vcpkg validation run microsoft/vcpkg#17119 fails because this path does not exist)
We could fix either, but the include file path is
messaging/eventhubs, plus it is more consistent with storage and keyvault.Go SDK has it under
messaging: https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/messaging/azeventhubs