Skip to content

Fix Eventhubs vcpkg manifest#4794

Merged
antkmsft merged 1 commit into
Azure:mainfrom
antkmsft:eventhubs-vcpkg
Jul 17, 2023
Merged

Fix Eventhubs vcpkg manifest#4794
antkmsft merged 1 commit into
Azure:mainfrom
antkmsft:eventhubs-vcpkg

Conversation

@antkmsft

Copy link
Copy Markdown
Member

Vcpkg CI currently fails: microsoft/vcpkg#17119

@antkmsft antkmsft added EngSys This issue is impacting the engineering system. Event Hubs labels Jul 15, 2023
@antkmsft antkmsft self-assigned this Jul 15, 2023
Comment thread sdk/eventhubs/azure-messaging-eventhubs/vcpkg.json
Comment thread sdk/eventhubs/azure-messaging-eventhubs/vcpkg/vcpkg.json

@ahsonkhan ahsonkhan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but we need to find why we are depending on storage and remove that.

If that's outside the scope of this PR and requires more work to address, let me know, and I can file an issue instead.

@ahsonkhan

Copy link
Copy Markdown
Contributor

If that's outside the scope of this PR and requires more work to address, let me know, and I can file an issue instead.

Per offline discussion, this is working as intended for how EventHubs works, and hence a separate issue.

@ahsonkhan

Copy link
Copy Markdown
Contributor

I was wondering what the failures/errors were in vcpkg.

One of them seems to be this:
https://dev.azure.com/vcpkg/public/_build/results?buildId=91832&view=logs&j=878666d5-db33-5b27-9e7d-b0c7ee352005&t=9a0acc60-e136-51ce-90f9-d151828126f7

C:\a\1\s\ports\azure-messaging-eventhubs-cpp\vcpkg.json:17:36: error: Trailing comma in an object
on expression: "name": "azure-core-amqp-cpp",

I am not sure how we are fixing that here.

The other issue is:
https://dev.azure.com/vcpkg/public/_build/results?buildId=91832&view=logs&j=878666d5-db33-5b27-9e7d-b0c7ee352005&t=3980505e-92f5-53ef-75a8-4f2e70b97516

2023-07-14T23:18:21.6352844Z ##[error]Found the following errors:
2023-07-14T23:18:21.6372669Z ##[error]versions/a-/azure-messaging-eventhubs-cpp.json(2,): error : azure-messaging-eventhubs-cpp is missing a version database file at version/a-/azure-messaging-eventhubs-cpp.json

@antkmsft antkmsft requested a review from ahsonkhan July 17, 2023 20:27
@antkmsft

Copy link
Copy Markdown
Member Author

@ahsonkhan, please re-review in the light of the fact that the dependency is correct.

Comment thread sdk/eventhubs/azure-messaging-eventhubs/vcpkg/vcpkg.json
@antkmsft antkmsft merged commit fd07336 into Azure:main Jul 17, 2023
@antkmsft antkmsft deleted the eventhubs-vcpkg branch July 17, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EngSys This issue is impacting the engineering system. Event Hubs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants