Always release to vcpkg daily branch#4522
Conversation
|
Not sure if this is a result of you running the changes in this PR, but FWIW, vcpkg daily validation PR (microsoft/vcpkg#17119) looks very good now - it includes changes for all the packages, has changes for 43 files, and we can see that all of them do build successfully in the vcpkg CI (* - at this very moment, linux pipeline there is still pending, but all others are successful, including ARM and UWP, which typically have the most problems). I.e. the PR serves the goal: I can go there and see that we are in good shape to release to vcpkg, it tells me that information, and it is complete and fresh. Yes, we could potentially have bugs in code, but the main thing I need that PR to tell me if we compile successfully in the vcpkg CI (code compiles on WIndows, Mac, Linux; ARM, UWP; and also the vcpkg manifest files are in the good shape. It is basically only the vcpkg CI that can confidently tell us about the problems with vcpkg manifest files). Any problems with or tests will fail during the release or during PRs, so it is not that if we have vcpkg validation PR as green, we are going to release the code that fails our tests - our CI will prevent us from doing that. |
|
And at this moment, Storage packages are missing from the PR, I don't understand. |
| { | ||
| "StaticConfigs": { | ||
| "Ubuntu22": { | ||
| "OSVmImage": "MMSUbuntu22.04", |
There was a problem hiding this comment.
Do you also want to remove this from the default matrix?
There was a problem hiding this comment.
It is removed from the other build matrix: https://github.com/Azure/azure-sdk-for-cpp/pull/4522/files#diff-6d57a4119ae22b0fede4d3aab5dff565cee910416d4eaa647d83e1d749c9b559L159
There was a problem hiding this comment.
Perhaps I'm missing something but that just shows removal of included: {} how does that map to this build configuration?
|
Most recent successful run -- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2707194&view=results |
| @@ -0,0 +1,22 @@ | |||
| { | |||
There was a problem hiding this comment.
minor but you left this file with the name quick in it.
* Always release to vcpkg daily branch * Release should also depend on PrePublishBuild
4 participants
Fixes #4422
Always pushes vcpkg up to the daily branch regardless of build/test results. The majority of skips of this job were from failures of flaky live tests, image problems, network/service problems, or other issues not relating to code defects.