Always release to vcpkg when doing Daily Release#4334
Conversation
antkmsft
left a comment
antkmsft
left a comment
There was a problem hiding this comment.
I understand this is a work in progress, but I approve and by that I mean that I like the intent of this change and I trust that you will verify that the fix does what you intend before you check in. I may return to re-review as you have more pushes, but in general I don't want to block you if you are ready.
|
I took the daily verification branch, manually merged all changes from |
|
So, the vcpkg PR was looking perfect, and the the daily run happened, and it replaced what's been there with a single commit for opentelemetry - https://github.com/microsoft/vcpkg/pull/17119/files. So, the problem was not fixed by me simply pushing all the right commits at one point. |
|
We'd still need this fix- the daily runs do not include all the packages. |
|
https://github.com/microsoft/vcpkg/compare/master...azure-sdk:vcpkg:djurek/verify-4334?expand=1 -- Testing with the pipelines |
|
Overriding check-enforcer, the failures are not relevant and testing was done in a manner other than using checks. |
|
/check-enforcer override |
|
The checks API appears to be pretty far behind on this PR. Closing and re-opening. |
Pull request was closed
* Always release to vcpkg when doing Daily Release * Add ability to skip live tests via variable * Use 1ES agents instead of Azure Pipelines
2 participants
No description provided.