fix(pipelines): correct invalid path filters in extension release pipelines#9241
fix(pipelines): correct invalid path filters in extension release pipelines#9241vhvb1989 wants to merge 2 commits into
Conversation
…elines Fixes #9216. Extension release pipelines referenced two non-existent paths in their trigger/pr path filters: - eng/pipelines/release-azd-extension.yml (does not exist) -> /eng/pipelines/templates/stages/release-azd-extension.yml - root go.mod (does not exist) -> removed from extension pipelines (each extension directory include already covers its own go.mod); repointed to cli/azd/go.mod in release-cli.yml Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c4c455d1-34ed-4738-9ace-4bc443304d60
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
|
Azure Pipelines: Successfully started running 18 pipeline(s). 4 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Corrects Azure DevOps release-pipeline path filters to reference existing files.
Changes:
- Points extension pipelines to the shared stage template.
- Removes invalid root
go.modfilters. - Uses
cli/azd/go.modfor CLI releases.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
eng/pipelines/release-ext-microsoft-azd-extensions.yml |
Corrects shared-template filters. |
eng/pipelines/release-ext-microsoft-azd-demo.yml |
Removes invalid module filters and corrects template paths. |
eng/pipelines/release-ext-microsoft-azd-concurx.yml |
Corrects shared-template filters. |
eng/pipelines/release-ext-microsoft-azd-ai-builder.yml |
Removes invalid module filters and corrects template paths. |
eng/pipelines/release-ext-azure-coding-agent.yml |
Corrects shared-template filters. |
eng/pipelines/release-ext-azure-appservice.yml |
Corrects extension release filters. |
eng/pipelines/release-ext-azure-ai-training.yml |
Corrects extension release filters. |
eng/pipelines/release-ext-azure-ai-toolboxes.yml |
Corrects extension release filters. |
eng/pipelines/release-ext-azure-ai-skills.yml |
Corrects extension release filters. |
eng/pipelines/release-ext-azure-ai-routines.yml |
Corrects extension release filters. |
eng/pipelines/release-ext-azure-ai-rle.yml |
Corrects extension release filters. |
eng/pipelines/release-ext-azure-ai-projects.yml |
Corrects extension release filters. |
eng/pipelines/release-ext-azure-ai-models.yml |
Corrects extension release filters. |
eng/pipelines/release-ext-azure-ai-inspector.yml |
Corrects extension release filters. |
eng/pipelines/release-ext-azure-ai-finetune.yml |
Corrects extension release filters. |
eng/pipelines/release-ext-azure-ai-connections.yml |
Corrects extension release filters. |
eng/pipelines/release-ext-azure-ai-agents.yml |
Corrects extension release filters. |
eng/pipelines/release-cli.yml |
Targets the actual CLI Go module. |
…r template The release-ext.yml.tmpl used by the extension scaffolder still generated the invalid trigger/pr path filters this PR removes. Mirror the corrections so newly scaffolded extension pipelines don't reintroduce the bug: - eng/pipelines/release-azd-extension.yml -> /eng/pipelines/templates/stages/release-azd-extension.yml - remove non-existent root go.mod include Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c4c455d1-34ed-4738-9ace-4bc443304d60
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
jongio
left a comment
There was a problem hiding this comment.
Verified the corrected filters against the repo. /eng/pipelines/templates/stages/release-azd-extension.yml and cli/azd/go.mod exist on main, while the old eng/pipelines/release-azd-extension.yml and root go.mod don't, so the prior paths filters matched nothing and contributed nothing to change detection.
The scaffolder template release-ext.yml.tmpl is updated to match, so newly generated extension pipelines won't reintroduce the invalid filters. That covers the earlier automated review note about the template.
Dropping root go.mod from the extension triggers is fine: each cli/azd/extensions/<id> filter already covers that extension's own go.mod.
Summary
Fixes #9216. Extension release pipelines (and
release-cli.yml) referenced non-existent paths in theirtrigger/prpathsfilters. Because these paths never match anything, they silently contributed nothing to change detection.Invalid paths corrected
1.
eng/pipelines/release-azd-extension.yml→/eng/pipelines/templates/stages/release-azd-extension.ymlThe referenced file does not exist; the real template each pipeline already
extendslives undertemplates/stages/. Fixed in bothtriggerandprfilters across all 17release-ext-*.ymlpipelines.2. root
go.mod(does not exist)There is no
go.modat the repo root — modules live atcli/azd/go.modand per-extensioncli/azd/extensions/<id>/go.mod.cli/azd/extensions/<id>), which covers that extension's owngo.mod.release-cli.yml: repointed tocli/azd/go.mod.Validation
Re-ran a path-existence audit over all
eng/pipelines/**/*.ymltrigger/prfilters: 0 invalid paths remain.Out of scope (noted in the issue audit)
.github/workflows/cspell-misc.ymlhas a staletemplates/**paths-ignoreentry, but it is intentionally kept in sync with thetemplatesignore in.vscode/cspell.misc.yaml, so it's left untouched here./eng/...) and relative (eng/...) forms; both are accepted by Azure DevOps. Not changed to keep this PR focused.