[Network] az network application-gateway ssl-cert create/update: Add --hsm to support Managed HSM#33353
Open
huiii99 wants to merge 12 commits into
Open
[Network] az network application-gateway ssl-cert create/update: Add --hsm to support Managed HSM#33353huiii99 wants to merge 12 commits into
az network application-gateway ssl-cert create/update: Add --hsm to support Managed HSM#33353huiii99 wants to merge 12 commits into
Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network application-gateway ssl-cert create | cmd network application-gateway ssl-cert create added parameter hsm |
||
| network application-gateway ssl-cert update | cmd network application-gateway ssl-cert update added parameter hsm |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
huiii99
changed the title
az network application-gateway ssl-cert create/update: Add --hsm to support Managed HSM az network application-gateway ssl-cert create/update: Add --hsm to support Managed HSM
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Managed HSM backing for Application Gateway SSL certificates in the az network application-gateway ssl-cert create/update commands by introducing an hsm property (API version 2025-07-01) and validating the behavior with a new scenario test.
Changes:
- Adds
--hsmsupport (with nested properties) to Application Gateway SSL certificate create/update flows (AAZ-generated commands). - Updates the
ssl-cert waitcommand and related schemas to2025-07-01and includes the newhsmshape in the response schema. - Adds a Managed HSM scenario test and updates an existing recording to use the newer API version.
Reviewed changes
Copilot reviewed 1 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py | Adds a new scenario test covering Managed HSM-backed SSL cert create/show/update/list/delete. |
| src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_network_app_gateway_with_private_ip.yaml | Updates recorded requests to api-version=2025-07-01 for Application Gateway operations impacted by the API bump. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/ssl_cert/_create.py | Introduces --hsm argument support and request mapping for SSL certificate creation. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/ssl_cert/_update.py | Introduces --hsm argument support and request mapping for SSL certificate updates. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/application_gateway/ssl_cert/_wait.py | Bumps API version to 2025-07-01 and extends the Application Gateway/SSL cert schema to include hsm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network application-gateway ssl-cert createaz network application-gateway ssl-cert updateDescription
Add Managed HSM support to Application Gateway SSL certificate commands.
resolve: #33263
aaz: Azure/aaz#1006
Testing Guide
azdev test test_network_app_gateway_ssl_cert_managed_hsm --liveHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.