{Compute} Migrate vm validator function of calling Compute module to aaz-based implementation#33348
Open
william051200 wants to merge 3 commits into
Open
{Compute} Migrate vm validator function of calling Compute module to aaz-based implementation#33348william051200 wants to merge 3 commits into
william051200 wants to merge 3 commits into
Conversation
william051200
requested review from
NoriZC,
teresaritorto and
yanzhudd
as code owners
❌AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
added
Compute
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the community gallery legal-terms lookup used by VM/VMSS creation validators from the azure.mgmt.compute client to the AAZ-based sig show-community implementation, aligning VM module behavior with the ongoing AAZ migration.
Changes:
- Update
sig show-communityAAZ command to use Compute API version2025-03-03and expand the 200-response schema to include flattenedpropertiesfields (includingcommunityMetadata/ EULA). - Switch
_validate_community_gallery_legal_agreement_acceptanceto call the AAZShowCommunitycommand instead ofcf_community_gallery().get(...).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/sig/_show_community.py |
Bumps API version and enriches response schema so AAZ output includes community gallery metadata (EULA, etc.). |
src/azure-cli/azure/cli/command_modules/vm/_validators.py |
Replaces mgmt-plane client call with AAZ sig show-community to retrieve the community gallery EULA during VM/VMSS create validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 'public_gallery_name': community_gallery_name | ||
| } | ||
| community_gallery_info = SigShowCommunity(cli_ctx=cmd.cli_ctx)(command_args=command_args) | ||
| eula = community_gallery_info['community_metadata']['eula'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vm createaz vmss createaz sig show-communityDescription
Migration from mgmt.compute to aaz-based
aaz Azure/aaz#1005
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.