Conversation
… Documentation_TextFormatting Agent-Logs-Url: https://github.com/Azure/autorest.typescript/sessions/9e830c96-7264-4433-a528-4a8e7a2b55b1 Co-authored-by: v-jiaodi <80496810+v-jiaodi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Verify and implement spector tests for scenario groups
Add spector integration tests for ClientDoc, ResponseAsBool, Documentation_Lists, and Documentation_TextFormatting
May 6, 2026
v-jiaodi
requested review from
JialinHuang803,
MaryGao,
joheredi and
qiaozha
as code owners
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements missing azure-modular spector integration tests for 4 scenario groups covering
@clientDoc,@responseAsBool, and documentation formatting scenarios.Changes
cadl-ranch-list.js— Added 3 new entries toazureModularTsps:azure/client-generator-core/client-docazure/client-generator-core/response-as-booldocumentationNew spec files:
azureClientGeneratorCoreClientDoc.spec.ts— Tests@clientDocdecorator (harvest POST with Plant body/response)azureClientGeneratorCoreResponseAsBool.spec.ts— Tests@responseAsBoolHEAD operations (204/404 both accepted)documentation.spec.ts— Tests all 6 documentation formatting scenarios acrossListsandTextFormattingoperation groupsGenerated client configs —
tspconfig.yaml+.gitignore+src/index.d.tsforclient-docandresponse-as-boolpathsKnown emitter limitation
@responseAsBooldeserialization is broken: the generated deserializer returnsresult.body(alwaysundefinedfor HEAD responses) instead of deriving the boolean from the status code. Boolean value assertions are omitted from theResponseAsBooltests; the API calls themselves pass. Root fix requires the emitter to emitreturn { body: result.status === "204" }in the generated deserializer.