Skip to content

Re-export RestError and isRestError from @azure/core-rest-pipeline for Azure flavor packages#3930

Draft
Copilot wants to merge 7 commits intomainfrom
copilot/re-export-resterror-isresterror
Draft

Re-export RestError and isRestError from @azure/core-rest-pipeline for Azure flavor packages#3930
Copilot wants to merge 7 commits intomainfrom
copilot/re-export-resterror-isresterror

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 22, 2026

  • Understand the issue: Re-export RestError and isRestError from @azure/core-rest-pipeline for Azure flavor generated packages (both RLC and Modular)
  • Implement for Modular packages: Add exportRestErrorTypes function in buildRootIndex.ts that adds export { RestError, isRestError } from "@azure/core-rest-pipeline" for Azure flavor packages
  • Implement for RLC packages: Add re-export in buildIndexFile.ts (rlc-common) using isAzurePackage check
  • Add unit test scenario for Modular root index (packages/typespec-ts/test/modularUnit/scenarios/classicClient/rootIndex.md)
  • Update existing modelsGenerator.md snapshots to include the new RestError export
  • Run full modular unit tests - 630 passed
  • Run RLC unit tests - 316 passed
  • Run rlc-common tests - 101 passed
  • Build passes successfully
  • Merge origin/main (Typescript generator initial version #1, commit 97b34fa) into branch and resolve conflicts
  • Merge origin/main (TS Generator tasks to be accomplished #2, commit acc77b3) into branch (true merge commit)
  • Run pnpm format to fix code formatting (function signature formatting in buildRootIndex.ts)
  • All tests pass: 316 RLC + 630 modular unit tests

…r Azure flavor packages

Agent-Logs-Url: https://github.com/Azure/autorest.typescript/sessions/2f9556da-31de-4a78-b7fb-e3e7697b051f

Co-authored-by: v-jiaodi <80496810+v-jiaodi@users.noreply.github.com>
Copilot AI changed the title [WIP] Re-export RestError and isRestError from @azure/core-rest-pipeline Re-export RestError and isRestError from @azure/core-rest-pipeline for Azure flavor packages Apr 22, 2026
Copilot AI requested a review from v-jiaodi April 22, 2026 06:49
@qiaozha qiaozha added HRLC P1 priority 1 labels Apr 22, 2026
@v-jiaodi
Copy link
Copy Markdown
Member

v-jiaodi commented May 6, 2026

@copilot pull main branch and resolve conflicts, then fix CI error.

…penai_modular with RestError exports

Agent-Logs-Url: https://github.com/Azure/autorest.typescript/sessions/8bf3d0c9-698e-4f57-9d71-39913c0f605a

Co-authored-by: v-jiaodi <80496810+v-jiaodi@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 6, 2026

@copilot pull main branch and resolve conflicts, then fix CI error.

Done in commit 97b34fa. Merged main into the branch, resolved the conflicts in ai/src/index.ts (combined NodeReadableStream from main with our RestError/isRestError exports) and batch_modular/review/batch.api.md (kept main version). Also added the RestError/isRestError exports and updated the api.md review files for openai_generic and openai_modular (both are Azure flavor via msinternal scope). All unit tests pass (630 modular, 316 RLC, 101 rlc-common).

@v-jiaodi
Copy link
Copy Markdown
Member

v-jiaodi commented May 7, 2026

@copilot pull main branch and resolve conflicts

…from our PR)

Co-authored-by: v-jiaodi <80496810+v-jiaodi@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 7, 2026

@copilot pull main branch and resolve conflicts

Done in commit acc77b3. The branch is now up to date with origin/main (true merge commit with both parents). Conflicts in the three index.ts files were resolved by keeping our RestError/isRestError re-exports. CI is currently running on the merged commit.

@v-jiaodi
Copy link
Copy Markdown
Member

v-jiaodi commented May 7, 2026

@copilot fix CI error.

…RestError exports for Azure flavor packages

Agent-Logs-Url: https://github.com/Azure/autorest.typescript/sessions/9dce25f4-fcb1-4083-84f7-deba3c986e40

Co-authored-by: v-jiaodi <80496810+v-jiaodi@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 7, 2026

@copilot fix CI error.

Fixed in commit e376f20. The CI failures were caused by the Azure-flavor integration test clients (index.d.ts files) not being updated with the new RestError/isRestError exports. Regenerated all four categories of integration test clients (azure-rlc, azure-modular, standard modular with azure flavor) and updated the typespec-test smoke test generated files.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dev.azure.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HRLC P1 priority 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-export RestError and isRestError from @azure/core-rest-pipeline for Azure flavor generated packages

4 participants