aks-desktop: Clean up knip findings#722
Open
skoeva wants to merge 3 commits into
Open
Conversation
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up unused exports/helpers and updates the repository’s knip configuration to reflect the current monorepo/plugin structure, with the goal of eliminating outstanding Knip findings.
Changes:
- Removed unused Kubernetes/CLI helper exports and narrowed
cli-runnerto the single currently-usedrunCommandWithOutputAPI. - Unexported (or removed) internal-only constants/helpers across several components to eliminate unused-export findings.
- Updated
knip.jsonworkspace entries/ignores to match the current plugin layout and stop scanning theai-assistantworkspace.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/aks-desktop/src/utils/kubernetes/cli-runner.ts | Removes unused K8s/az helper exports; keeps only the CLI runner API used by Prometheus utilities/tests. |
| plugins/aks-desktop/src/components/Metrics/hooks/useCardMetrics.ts | Removes an unused cache-clearing helper export. |
| plugins/aks-desktop/src/components/GitHubPipeline/hooks/usePipelineAnnotationSync.ts | Makes a tenant annotation constant internal-only (no longer exported). |
| plugins/aks-desktop/src/components/GitHubPipeline/constants.ts | Removes an unused exported set of Copilot bot usernames. |
| plugins/aks-desktop/src/components/DeployWizard/components/types.ts | Removes an unused helper (bumpWithUnit). |
| plugins/aks-desktop/src/components/DeployTab/hooks/useClusterDeployStatus.ts | Makes deploy/pipeline annotation constants internal-only (no longer exported). |
| plugins/aks-desktop/src/components/CreateAKSProject/validators.ts | Unexports internal validation helpers used only within the module. |
| plugins/aks-desktop/src/components/CreateAKSProject/types.ts | Removes an unused exported role descriptions map. |
| knip.json | Retunes Knip workspace entrypoints/ignores/dependency ignores for the current layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes resolve all outstanding knip findings by tuning the knip config for the current plugin layout, unexporting internal-only symbols, and removing dead helpers left behind when the ai-assistant plugin moved upstream.
Testing
npm run knipreports zero issues