Revert .NET 10 custom code support for v5.959 hotfix#9170
Open
lambrianmsft wants to merge 16 commits into
Open
Revert .NET 10 custom code support for v5.959 hotfix#9170lambrianmsft wants to merge 16 commits into
lambrianmsft wants to merge 16 commits into
Conversation
Reverts commit 3059380 from the v5.959 hotfix branch to restore the pre-.NET 10 custom code project defaults. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | Keep as-is; optionally include #9144 in title for visibility. |
| Commit Type | ✅ | No change needed. |
| Risk Level | ✅ | Label and body match (low). |
| What & Why | ✅ | No change needed. |
| Impact of Change | ✅ | No change needed. |
| Test Plan | ✅ | Ensure CI PR Coverage Check passes after heap adjustment. |
| Contributors | Optional: add credits if applicable. | |
| Screenshots/Videos | Not applicable. |
Final message
This PR is a revert; per the revert policy it is eligible to be approved immediately. The PR body and labels are well-formed and the declared risk (low) matches the label present on the PR. I recommend merging once the repo CI (including the PR Coverage Check rerun) completes successfully.
Suggested small improvements (optional):
- Add the issue number in the PR title for easier discovery (e.g., append
(fixes #9144)). - If anyone else contributed, add them to the Contributors section for credit.
Thank you — this PR can be merged after CI passes.
Last updated: Fri, 15 May 2026 02:57:45 GMT
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Run the VS Code designer extension unit test script through node with an explicit heap size so full-package Istanbul coverage can complete in CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collect VS Code designer Istanbul coverage only for changed package source files during PR runs so coverage generation matches the changed-file gate and avoids CI heap exhaustion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Resolve changed VS Code designer coverage files from the pull request event base SHA first, so CI does not fall back to all-source Istanbul coverage when remote branch refs are unavailable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Allow test:extension-unit tasks to receive GitHub PR base-ref environment values so VS Code designer coverage can scope instrumentation to changed files in CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Have CI write the changed VS Code designer source list before extension-unit tests and let the package Vitest config read that list, avoiding all-source Istanbul coverage under Turbo. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Switch the VS Code designer Vitest coverage provider from Istanbul to V8 so the full extension-unit suite can complete in CI while still emitting lcov for the changed-file coverage gate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Run VS Code designer Vitest through a small Node wrapper that sets NODE_OPTIONS before Vitest starts, allowing worker processes to inherit the larger heap in CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Run full extension-unit tests without coverage in Test Runner, and run targeted VS Code designer coverage only in the PR coverage workflow so the changed-file gate has data without exhausting CI memory. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the sharded VS Code designer Vitest wrapper aligned with the package exclude rules by skipping src/test harness files when discovering unit test shards. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Default the VS Code designer no-coverage unit test wrapper to one test file per Vitest process so memory-heavy files cannot accumulate heap across a shard in CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
Reverts
.NET 10 custom code project supportfrom the v5.959 hotfix line and keeps the restored unit coverage in the same PR so this can merge directly intohotfix/v5.959.Why:
Affected areas:
apps/vs-code-designer: custom code function/project steps, code project base, codeful workflow creation, workflowswitchToDotnetProject, debug/custom-code/dotnet/codeless utility tests, and reverted .NET 8 defaults/templates.apps/vs-code-react: create workspace .NET framework step tests and reverted .NET 8 framework UI behavior..github/workflows/pr-coverage.yml: CI-only Node heap increase for the coverage test step to avoid VS Code extension coverage OOM.Supersedes #9169, which was closed so this PR can carry both the revert and coverage fix directly into
hotfix/v5.959.Fixes #9144
Type of Change
Impact of Change
Users
Developers
System
Risk Level
Risk notes:
Test Plan
pnpm install --frozen-lockfileduring the hotfix setup.pnpm exec biome check --write <changed test files>.apps/vs-code-designerVitest coverage: 12 files, 192 tests passed.apps/vs-code-reactVitest coverage: 2 files, 25 tests passed.pnpm run build:extensionduring the revert validation.Screenshots / Videos
Not applicable - VS Code hotfix revert, unit coverage restoration, and CI coverage stability update; no new UI surface.
Contributors
N/A