Skip to content

Improve Tags/deny-resource-without-tag: add empty-value check, excludedResourceTypes param, and description #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hendersonandrade wants to merge 1 commit into
base: main
Choose a base branch
from
+52 −10
Open

Improve Tags/deny-resource-without-tag: add empty-value check, excludedResourceTypes param, and description #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions policyDefinitions/Tags/deny-resource-without-tag/azurepolicy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"type": "Microsoft.Authorization/policyDefinitions",
"properties": {
"displayName": "Deny-resource-without-tag",
"description": "need to add description",
"description": "Requires that a specified tag exists and is not empty on resources. Resource types that do not support tags can be excluded via the excludedResourceTypes parameter. Does not apply to resource groups (mode Indexed).",
"metadata": {
"version": "1.0.0",
"version": "1.1.0",
"category": "Tags"
},
"mode": "Indexed",
Expand All @@ -14,9 +14,18 @@
"type": "String",
"metadata": {
"displayName": "Tag name",
"description": "Name of the tag to enforce"
"description": "Name of the tag to enforce, such as 'Environment' or 'CostCenter'."
}
},
"excludedResourceTypes": {
"type": "Array",
"metadata": {
"displayName": "Excluded Resource Types",
"description": "Resource types to exclude from this policy. Useful for resource types that do not support tags.",
"strongType": "ResourceType"
},
"defaultValue": []
},
"effect": {
"type": "String",
"metadata": {
Expand All @@ -33,10 +42,22 @@
},
"policyRule": {
"if": {
"allof": [
"allOf": [
{
"field": "type",
"notIn": "[parameters('excludedResourceTypes')]"
},
{
"field": "[concat('tags[', parameters('tagName'), ']')]",
"exists": "false"
"anyOf": [
{
"field": "[concat('tags[', parameters('tagName'), ']')]",
"exists": "false"
},
{
"field": "[concat('tags[', parameters('tagName'), ']')]",
"equals": ""
}
]
}
]
},
Expand Down
11 changes: 10 additions & 1 deletion policyDefinitions/Tags/deny-resource-without-tag/azurepolicy.parameters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,18 @@
"type": "String",
"metadata": {
"displayName": "Tag name",
"description": "Name of the tag to enforce"
"description": "Name of the tag to enforce, such as 'Environment' or 'CostCenter'."
}
},
"excludedResourceTypes": {
"type": "Array",
"metadata": {
"displayName": "Excluded Resource Types",
"description": "Resource types to exclude from this policy. Useful for resource types that do not support tags.",
"strongType": "ResourceType"
},
"defaultValue": []
},
"effect": {
"type": "String",
"metadata": {
Expand Down
18 changes: 15 additions & 3 deletions policyDefinitions/Tags/deny-resource-without-tag/azurepolicy.rules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,21 @@
{
"if": {
"allof": [
"allOf": [
{
"field": "[concat('tags[', parameters('tagName'), ']')]",
"exists": "false"
"field": "type",
"notIn": "[parameters('excludedResourceTypes')]"
},
{
"anyOf": [
{
"field": "[concat('tags[', parameters('tagName'), ']')]",
"exists": "false"
},
{
"field": "[concat('tags[', parameters('tagName'), ']')]",
"equals": ""
}
]
}
]
},
Expand Down