Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(gpu): pre-bake NVIDIA CUDA kernel module into the VHD #8661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat(gpu): pre-bake NVIDIA CUDA kernel module into the VHD #8661
Changes from all commits
1430b3052838132bf9460ca51d1eFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question about this: the Opt-in here means if the feature flag FEATURE_FLAGS=NVIDIA_CUDA_PREBAKE is provided in the GPU SKU build pipeline, right?
Does that mean a non-GPU node could still use this GPU SKU VHD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand the scenario. If that's the case, why not only GPU node using GPU SKU VHD?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flag will be set in the VHD build pipeline.
There is no separate GPU VHD today. GPU and non-GPU x86 nodes boot from the same Ubuntu VHD (the CUDA driver image is already cached in it today). Only GB200 (arm64) has its own dedicated image.
So when NVIDIA_CUDA_PREBAKE is on, the prebaked module lands in that shared Ubuntu VHD, and a non-GPU node that boots from it inherits an installed driver it doesn't need. That's exactly why
cleanUpPrebakedGPUDriver runs on non-GPU nodes — to remove the dead weight (and stop nvidia.ko rebuilding on every │ kernel patch). It's a no-op on VHDs that weren't prebaked."Why not a GPU-only VHD?" is fair — it would avoid the non-GPU footprint entirely, but it's a bigger change (new build target + RP logic to pick it for GPU │ pools), and higher storage costs with more SKUs to manage.
It's on the table as a future optimization; for now, shared VHD + teardown keeps the footprint minimal without splitting the image matrix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks for the explanations
Uh oh!
There was an error while loading. Please reload this page.