-
Notifications
You must be signed in to change notification settings - Fork 264
feat(rcv1p): unify cert bootstrap flow and add Windows CA refresh task #8096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
9ad33d3
609fdad
b480d82
a0ee082
0b781af
3ee2a7a
b316838
b738dee
4a64c63
852b7e6
16b6cf3
71d8c41
93440be
7e94123
25fe4b6
e78ca61
daec885
97a1576
a28917b
38bf707
b83cf88
48bae5a
d0fa085
195e476
a495382
2c6b703
0d1694a
f815b79
bb594e1
d40f6e7
40e7553
9742f2c
f7a6079
bb5fd8f
2131c91
f82563f
f86de39
bea6624
6ef8fa3
bd71472
cfa3152
dfc79bb
89afde4
08954ba
d863e83
ad7cb38
6150672
d5927c3
0ef6dd0
268c891
147cfe1
8685a99
53e488b
4015224
85dd9c9
e1f5b85
9913e0d
8ed0fe1
476efb2
daeab33
970bfba
ce58de7
d149247
f9e6702
a33ed3f
91f842d
e833c14
2f2e091
5270e32
f465e4e
de3ffe8
1e93ea2
35e1d3d
7f82fad
e612a60
dc31b21
2b8f638
b55d529
45af31e
d0e9d44
d503293
0dedd6e
7fd3907
b6e6361
7d81e39
0f78241
44c32b7
2634bb5
749c990
c02ec7c
188c615
abd9e61
a0f3726
ef75027
0b7ff16
f642106
71b7776
f056ae6
0811f20
e94da52
625badf
f20c87e
3f1c640
669db6c
2926323
30ab591
7e59539
18ddf06
555e114
9f4af93
9f5e36b
70ab404
9f963d5
b450d67
99068ce
85a91bf
af51a92
8ee90d4
ad7e2d1
b5b33ee
1b4e514
2cf6757
9923f06
7423215
f345afa
9bd95a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| name: $(Date:yyyyMMdd)$(Rev:.r) | ||
| variables: | ||
| TAGS_TO_RUN: "rcv1pcertmode=true" | ||
| SKIP_E2E_TESTS: false | ||
| E2E_GO_TEST_TIMEOUT: "75m" | ||
| trigger: none | ||
| pr: none | ||
| jobs: | ||
| - template: ./templates/e2e-template.yaml | ||
| parameters: | ||
| name: RCV1P Cert Mode Tests | ||
| IgnoreScenariosWithMissingVhd: false | ||
| variableGroup: ab-e2e-tme-rcv1p | ||
| # The RCV1P testing subscription does not have platform auto-injection enabled, | ||
| # so the E2E framework explicitly injects opt-in tags on each VMSS. | ||
| rcv1pTagsAutoInjected: "false" | ||
|
rchincha marked this conversation as resolved.
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| echo $(date),$(hostname) > ${PROVISION_OUTPUT}; | ||
| {{if getIsAksCustomCloud .CustomCloudConfig}} | ||
| REPO_DEPOT_ENDPOINT="{{.CustomCloudConfig.RepoDepotEndpoint}}" | ||
| {{getInitAKSCustomCloudFilepath}} >> /var/log/azure/cluster-provision.log 2>&1; | ||
| {{end}} | ||
| LOCATION="{{getCloudLocation .}}" | ||
|
rchincha marked this conversation as resolved.
rchincha marked this conversation as resolved.
|
||
| {{getInitAKSCustomCloudFilepath}} >> /var/log/azure/cluster-provision.log 2>&1; | ||
|
rchincha marked this conversation as resolved.
rchincha marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should change the name of this template func: maybe
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was planning a follow up PR that cleans up references to "custom" after this PR lands. Also see my comment below. But ok either way. |
||
| /usr/bin/nohup /bin/bash -c "/bin/bash /opt/azure/containers/provision_start.sh" | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is going to monitor this pipeline and address any issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably include an explicit run of this pipeline within our daily build system we use for official releases, that way we're guaranteed to have visibility during official release flows
though at the end of the day it's going to be on us to deal with failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be enabled in the TME tenant and probably as a async nightly so that it doesn't interfere with "immediate" tests (PRs, etc)