feat(config): add Go template AST validator for bicepparam files#255
Open
geoberle wants to merge 1 commit into
Open
feat(config): add Go template AST validator for bicepparam files#255geoberle wants to merge 1 commit into
geoberle wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Go text/template AST-based validator to ensure .bicepparam template content only uses simple field access (e.g. {{ .field.name }}), preventing developers from relying on template constructs that EV2 will not honor.
Changes:
- Introduces
ValidateSimpleFieldAccess([]byte) errorto parse templates and walk the AST, collecting restricted-construct violations with line numbers. - Adds unit tests covering allowed field access patterns, common disallowed constructs (if/range/with, variables, function calls, pipes, template invocation), and line-number reporting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| config/validate.go | Implements Go template parsing + AST walk to detect and report restricted constructs. |
| config/validate_test.go | Adds test coverage for allowed/disallowed constructs and expected error messages/line numbers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
In EV2, Go template field lookups in bicepparam files are translated
into scope bindings, but complex constructs (range, if, variables,
functions) are silently ignored. templatize processes the full Go
template locally, giving developers false confidence that these
constructs work — they don't once deployed via EV2.
Add ValidateSimpleFieldAccess() that parses templates and walks the AST,
allowing only simple field access ({{ .field.name }}). Returns all
violations with line numbers.
https://redhat.atlassian.net/browse/ARO-27904
geoberle
force-pushed
the
gotmp-ast-guards
branch
from
747bcac to
4ef93e8
Compare
stevekuznetsov
left a comment
stevekuznetsov
left a comment
Contributor
There was a problem hiding this comment.
Love it.
/lgtm
/approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In EV2, Go template field lookups in bicepparam files are translated into scope bindings, but complex constructs (range, if, variables, functions) are silently ignored. templatize processes the full Go template locally, giving developers false confidence that these constructs work — they don't once deployed via EV2.
Add ValidateSimpleFieldAccess() that parses templates and walks the AST, allowing only simple field access (
{{ .field.name }}). Returns all violations with line numbers.https://redhat.atlassian.net/browse/ARO-27904
/hold until all current issues in ARO-HCP and sdp-pipelines have been resolved