Fix aks-flex-config release schema#203
Open
anson627 wants to merge 2 commits into
Open
Conversation
anson627
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the workstation-side scripts/aks-flex-config generator to emit legacy field aliases alongside the current RP-shaped config, preserving compatibility with the currently released aks-flex-node binary while the config schema evolves.
Changes:
- Always emit legacy
kubernetes.versionalongsidecomponents.kubernetes. - In bootstrap-token mode, emit legacy kubelet aliases (
node.kubelet.serverURLandnode.kubelet.dnsServiceIP) alongside current fields. - Add a Python
unittestmodule to assert these legacy aliases are present and correct in identity and bootstrap-token modes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/aks-flex-config | Adds legacy config aliases (kubernetes.version, kubelet serverURL/dnsServiceIP) to generated configs. |
| scripts/aks_flex_config_test.py | Adds Python unit tests validating legacy alias fields for identity and bootstrap-token config generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+6
| import importlib.machinery | ||
| import importlib.util | ||
| import types | ||
| import unittest | ||
| from pathlib import Path | ||
| from unittest import mock |
Comment on lines
+8
to
+12
|
|
||
| SCRIPT_PATH = Path(__file__).with_name("aks-flex-config") | ||
|
|
||
|
|
||
| def load_helper(): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces legacy field aliases in the generated AKS flex node config to maintain compatibility with the current released
aks-flex-nodebinary while the config schema is evolving. It also adds tests to ensure these legacy fields are present and correct in both identity and bootstrap-token modes.