Fix kubeadm E2E bootstrap group#202
Open
bcho wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the kubeadm-based E2E node join flow to include kubeadm’s default bootstrap group in both the RBAC bindings and the bootstrap token’s auth-extra-groups, addressing Unauthorized errors when kubeadm E2E nodes attempt to create kubelet client CSRs.
Changes:
- Introduce a single constant for kubeadm’s default bootstrap group (
system:bootstrappers:kubeadm:default-node-token). - Add that group to all kubeadm E2E bootstrap-related RBAC subject lists alongside
system:bootstrappers:aks-flex-node. - Emit both groups in the created bootstrap token Secret via
auth-extra-groups.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+60
to
+65
| if command -v crictl >/dev/null 2>&1; then | ||
| sudo crictl rmi --prune || true | ||
| fi | ||
|
|
||
| sudo journalctl --vacuum-time=1d || true | ||
|
|
Comment on lines
+176
to
+178
| # Keep E2E runs isolated from stale or corrupt runner-global kubeconfig state. | ||
| E2E_KUBECONFIG="${E2E_KUBECONFIG:-${E2E_WORK_DIR}/kubeconfig}" | ||
| export KUBECONFIG="${E2E_KUBECONFIG}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation