Remove redundant PDF file opening in loop - #75
Open
Gustavo R. Ayala (agustavo87) wants to merge 1 commit into
Open
Remove redundant PDF file opening in loop#75Gustavo R. Ayala (agustavo87) wants to merge 1 commit into
Gustavo R. Ayala (agustavo87) wants to merge 1 commit into
Conversation
Remove unnecessary pymupdf.open() call inside the page iteration loop. The PDF was being reopened on every page unnecessarily. Also adds explicit doc.close() for proper resource cleanup.
Author
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove unnecessary pymupdf.open() call inside the page iteration loop. The PDF was being reopened on every page unnecessarily.
Also adds explicit doc.close() for proper resource cleanup.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Remove images converted
page_*.pnginnotebooksandnotebooks/SpanishRun the corresponding sections of
chat_pdf_images.ipynbnotebooks, until the## Convert PDFs to imagespython code block where the pdfs are converted to images (ensure dependencies installed) .What to Check
Check that the
page_*.pngfiles are created correctly (14 pages)