Skip to content

DankKDEConnect: fix last device clipped in control center detail #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kanghengliu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DankKDEConnect: fix last device clipped in control center detail #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions DankKDEConnect/DankKDEConnect.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ PluginComponent {
onCcWidgetExpanded: PhoneConnectService.detectBackend()

ccDetailContent: Component {
KDEConnectDetailContent {
listHeight: 300
}
KDEConnectDetailContent {}
}

onPluginServiceChanged: {
Expand Down
5 changes: 3 additions & 2 deletions DankKDEConnect/components/KDEConnectDetailContent.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Rectangle {
id: root

property var parentPopout: null
property int listHeight: 280
property string shareDeviceId: ""

implicitHeight: contentColumn.implicitHeight + Theme.spacingM * 2
Expand All @@ -25,6 +24,7 @@ Rectangle {
spacing: Theme.spacingS

RowLayout {
id: headerRow
spacing: Theme.spacingS
width: parent.width

Expand Down Expand Up @@ -72,14 +72,15 @@ Rectangle {
}

Rectangle {
id: dividerLine
height: 1
width: parent.width
color: Qt.rgba(Theme.outline.r, Theme.outline.g, Theme.outline.b, 0.12)
}

Item {
width: parent.width
height: root.listHeight
height: Math.max(0, root.height - headerRow.height - dividerLine.height - Theme.spacingS * 2 - Theme.spacingM * 2)

Column {
anchors.centerIn: parent
Expand Down