feat(battery): add options to toggle percentage and remaining time#2672
Merged
Purian23 merged 4 commits intoJun 22, 2026
Merged
Conversation
a98853a to
4b15f17
Compare
4b15f17 to
1aefd9f
Compare
1aefd9f to
9ac5634
Compare
Purian23
requested changes
Jun 21, 2026
Purian23
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR!
-
Add
SettingsSpec.jsentries The four new globals (showBatteryPercent,showBatteryPercentOnlyOnBattery,showBatteryTime, andshowBatteryTimeOnlyOnBattery) aren't in settings spec yet. Let's get those added near the other widget defaults. -
Vertical bar combined display The
horizontalDisplayTextcombines percent + time, butverticalDisplayTextdrops the time when percentage is on.
Everything else looks good, appreciate the contribution!
Contributor
Author
|
@Purian23 I made some changes to the battery widget in the vertical bar to make it look more symmetrical when using the remaining time option.
|
Purian23
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR implements customization options for the battery widget on the Dank Bar:
95%) on the bar pill.3h 15m/45m) on the bar pill.95% (3h 15m).270to prevent translation cut-offs (such as "Show Percentage" cutting off in narrow configurations).Type of change
Related issues
Closes #1853
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings