Add killedPids property and process killing logic#2588
Open
Harshjeet wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hey @Harshjeet thanks for the PR, but is this a revision of #2567 ? If yes, please ensure to communicate that with us so we're not trying to review both and or close the other one out commenting this PR supersedes it. We will finish the review after your confirmation. |
Author
|
Hi... |
Collaborator
|
Did you decide to drop the animation portion? |
Author
|
Yes i have drop the bubble animation with simple slide one. |
Collaborator
|
Hi @Harshjeet, thanks for updating this! The infinite binding loop is fully fixed, and the transition approach is much cleaner. We just have a couple of quick things to polish up before this is ready to merge:
Once these are sorted, we should be good to go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Related issues
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings