Skip to content

Add killedPids property and process killing logic#2588

Open
Harshjeet wants to merge 1 commit into
AvengeMedia:masterfrom
Harshjeet:patch-1
Open

Add killedPids property and process killing logic#2588
Harshjeet wants to merge 1 commit into
AvengeMedia:masterfrom
Harshjeet:patch-1

Conversation

@Harshjeet

@Harshjeet Harshjeet commented Jun 6, 2026

Copy link
Copy Markdown

Description

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Related issues

Screenshots / video

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dlx-docs to document any new behaviors: https://github.com/AvengeMedia/DankLinux-Docs

@Purian23

Purian23 commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Hey @Harshjeet thanks for the PR, but is this a revision of #2567 ? If yes, please ensure to communicate that with us so we're not trying to review both and or close the other one out commenting this PR supersedes it. We will finish the review after your confirmation.

@Harshjeet

Copy link
Copy Markdown
Author

Hi...
Yes this is revision of prev pr #2567.

@Purian23

Purian23 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Did you decide to drop the animation portion?

@Harshjeet

Copy link
Copy Markdown
Author

Yes i have drop the bubble animation with simple slide one.

@Purian23

Copy link
Copy Markdown
Collaborator

Hi @Harshjeet, thanks for updating this! The infinite binding loop is fully fixed, and the transition approach is much cleaner.

We just have a couple of quick things to polish up before this is ready to merge:

  1. Stability Guard (PID 0): In your transition's ScriptAction, calling Quickshell.execDetached(["kill", processItemRoot.processPid.toString()]) could run kill 0 if the process list updates mid-animation and the data becomes null. Since kill 0 kills the shell's process group, this will crash the whole desktop session.
    • Fix: Call the existing service helper DgopService.killProcess(processItemRoot.processPid) instead, which already guards against PIDs <= 0.
  2. Height Animation Snap: Having isKilled ? 0 : in the main height property declaration causes the row height to snap to 0 instantly before the transition starts.
    • Fix: Remove the isKilled ? 0 : check from the height declaration so the "killed" state transition can animate it smoothly from its current height to 0.
  3. Respect User Preferences: Please check !Theme.snapListModelChanges before enabling list view transitions on the search results, so users with animations disabled aren't forced to see them.

Once these are sorted, we should be good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants