Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Add Assembler patterns#8248

Draft
richtabor wants to merge 27 commits into
trunkfrom
add/assembler-patterns
Draft

Add Assembler patterns#8248
richtabor wants to merge 27 commits into
trunkfrom
add/assembler-patterns

Conversation

@richtabor

@richtabor richtabor commented Oct 9, 2024

Copy link
Copy Markdown

This is an experimental pr exploring a number of improvements collectively. I'm splitting out these into individual pull requests.

@github-actions

github-actions Bot commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

Preview changes

I've detected changes to the following themes in this PR: Assembler, DOS, Epi, LeanCV.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@richtabor richtabor force-pushed the add/assembler-patterns branch from d8d6853 to 1646475 Compare December 5, 2024 16:29
@github-actions

github-actions Bot commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

Theme-Check results

assembler: There are required changes on the theme ❌.

❎ REQUIRED

  • blueprint-content.xml XML file found. This file must not be in the production version of the theme.

dos: There are required changes on the theme ❌.

❎ REQUIRED

  • Screenshot is wrong size! Detected: 1440x1080. Maximum allowed size is 1200x900px.
💡 RECOMMENDED (1)
  • Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.

epi: There are required changes on the theme ❌.

❎ REQUIRED

  • Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).

leancv: No changes required ✅.

⚠️ WARNING (1)
  • Found ="<?php esc_html_e(' src='<?php echo esc_url( get_styleshee

@github-actions

github-actions Bot commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

Theme-Check results

assembler: There are required changes on the theme ❌.

❎ REQUIRED

  • blueprint-content.xml XML file found. This file must not be in the production version of the theme.

dos: There are required changes on the theme ❌.

❎ REQUIRED

  • Screenshot is wrong size! Detected: 1440x1080. Maximum allowed size is 1200x900px.
💡 RECOMMENDED (1)
  • Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.

epi: There are required changes on the theme ❌.

❎ REQUIRED

  • Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).

leancv: No changes required ✅.

⚠️ WARNING (1)
  • Found ="<?php esc_html_e(' src='<?php echo esc_url( get_styleshee

@MaggieCabrera

Copy link
Copy Markdown
Contributor

Is this one still relevant, @richtabor ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants