-
Notifications
You must be signed in to change notification settings - Fork 4
Added tests for described Exoskeleton functionality #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anigeluk
wants to merge
20
commits into
Automattic:master
Choose a base branch
from
anigeluk:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2261988
Prevent Exoskeleton dying when under test
anigeluk 01a118e
Test skeleton in place
anigeluk 405fd3b
Add tests for the public rule adding methods
anigeluk 42b1262
Start testing the REST API calls
anigeluk ad55ba0
Remove test that had been moved to another class
anigeluk bcadf1a
Indentation change
anigeluk 3e23eae
Added tests for window expiry and methods
anigeluk 50360ae
Remaining rest server tests
anigeluk e9f2ac6
Code linted and commented.
anigeluk c28e5d5
Added check for overwriting existing rules
anigeluk 457a902
Added tests of internal rule validation method
anigeluk f9969d6
refactored to use data provider
anigeluk 61f70f1
Check rules on any method apply across different methods
anigeluk 5b9604a
Add rule validation tests
anigeluk b7bb0f4
added testing of invalid data types for rules
anigeluk cad8816
add tests for process_custom_routes rule with multiple methods and us…
anigeluk 9a94812
add test for limits applied on rule with multiple methods
anigeluk c3738e4
Added a space to prevent coding standard error in the line added to p…
anigeluk 67013c4
Fix coding standards errors
anigeluk f3e2790
Refactor to remove unnecesary data providers and move cleanup to the …
anigeluk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| if [ $# -lt 3 ]; then | ||
| echo "usage: $0 <db-name> <db-user> <db-pass> [db-host] [wp-version] [skip-database-creation]" | ||
| exit 1 | ||
| fi | ||
|
|
||
| DB_NAME=$1 | ||
| DB_USER=$2 | ||
| DB_PASS=$3 | ||
| DB_HOST=${4-localhost} | ||
| WP_VERSION=${5-latest} | ||
| SKIP_DB_CREATE=${6-false} | ||
|
|
||
| WP_TESTS_DIR=${WP_TESTS_DIR-/tmp/wordpress-tests-lib} | ||
| WP_CORE_DIR=${WP_CORE_DIR-/tmp/wordpress/} | ||
|
|
||
| download() { | ||
| if [ `which curl` ]; then | ||
| curl -s "$1" > "$2"; | ||
| elif [ `which wget` ]; then | ||
| wget -nv -O "$2" "$1" | ||
| fi | ||
| } | ||
|
|
||
| if [[ $WP_VERSION =~ [0-9]+\.[0-9]+(\.[0-9]+)? ]]; then | ||
| WP_TESTS_TAG="tags/$WP_VERSION" | ||
| elif [[ $WP_VERSION == 'nightly' || $WP_VERSION == 'trunk' ]]; then | ||
| WP_TESTS_TAG="trunk" | ||
| else | ||
| # http serves a single offer, whereas https serves multiple. we only want one | ||
| download http://api.wordpress.org/core/version-check/1.7/ /tmp/wp-latest.json | ||
| grep '[0-9]+\.[0-9]+(\.[0-9]+)?' /tmp/wp-latest.json | ||
| LATEST_VERSION=$(grep -o '"version":"[^"]*' /tmp/wp-latest.json | sed 's/"version":"//') | ||
| if [[ -z "$LATEST_VERSION" ]]; then | ||
| echo "Latest WordPress version could not be found" | ||
| exit 1 | ||
| fi | ||
| WP_TESTS_TAG="tags/$LATEST_VERSION" | ||
| fi | ||
|
|
||
| set -ex | ||
|
|
||
| install_wp() { | ||
|
|
||
| if [ -d $WP_CORE_DIR ]; then | ||
| return; | ||
| fi | ||
|
|
||
| mkdir -p $WP_CORE_DIR | ||
|
|
||
| if [[ $WP_VERSION == 'nightly' || $WP_VERSION == 'trunk' ]]; then | ||
| mkdir -p /tmp/wordpress-nightly | ||
| download https://wordpress.org/nightly-builds/wordpress-latest.zip /tmp/wordpress-nightly/wordpress-nightly.zip | ||
| unzip -q /tmp/wordpress-nightly/wordpress-nightly.zip -d /tmp/wordpress-nightly/ | ||
| mv /tmp/wordpress-nightly/wordpress/* $WP_CORE_DIR | ||
| else | ||
| if [ $WP_VERSION == 'latest' ]; then | ||
| local ARCHIVE_NAME='latest' | ||
| else | ||
| local ARCHIVE_NAME="wordpress-$WP_VERSION" | ||
| fi | ||
| download https://wordpress.org/${ARCHIVE_NAME}.tar.gz /tmp/wordpress.tar.gz | ||
| tar --strip-components=1 -zxmf /tmp/wordpress.tar.gz -C $WP_CORE_DIR | ||
| fi | ||
|
|
||
| download https://raw.github.com/markoheijnen/wp-mysqli/master/db.php $WP_CORE_DIR/wp-content/db.php | ||
| } | ||
|
|
||
| install_test_suite() { | ||
| # portable in-place argument for both GNU sed and Mac OSX sed | ||
| if [[ $(uname -s) == 'Darwin' ]]; then | ||
| local ioption='-i .bak' | ||
| else | ||
| local ioption='-i' | ||
| fi | ||
|
|
||
| # set up testing suite if it doesn't yet exist | ||
| if [ ! -d $WP_TESTS_DIR ]; then | ||
| # set up testing suite | ||
| mkdir -p $WP_TESTS_DIR | ||
| svn co --quiet https://develop.svn.wordpress.org/${WP_TESTS_TAG}/tests/phpunit/includes/ $WP_TESTS_DIR/includes | ||
| svn co --quiet https://develop.svn.wordpress.org/${WP_TESTS_TAG}/tests/phpunit/data/ $WP_TESTS_DIR/data | ||
| fi | ||
|
|
||
| if [ ! -f wp-tests-config.php ]; then | ||
| download https://develop.svn.wordpress.org/${WP_TESTS_TAG}/wp-tests-config-sample.php "$WP_TESTS_DIR"/wp-tests-config.php | ||
| # remove all forward slashes in the end | ||
| WP_CORE_DIR=$(echo $WP_CORE_DIR | sed "s:/\+$::") | ||
| sed $ioption "s:dirname( __FILE__ ) . '/src/':'$WP_CORE_DIR/':" "$WP_TESTS_DIR"/wp-tests-config.php | ||
| sed $ioption "s/youremptytestdbnamehere/$DB_NAME/" "$WP_TESTS_DIR"/wp-tests-config.php | ||
| sed $ioption "s/yourusernamehere/$DB_USER/" "$WP_TESTS_DIR"/wp-tests-config.php | ||
| sed $ioption "s/yourpasswordhere/$DB_PASS/" "$WP_TESTS_DIR"/wp-tests-config.php | ||
| sed $ioption "s|localhost|${DB_HOST}|" "$WP_TESTS_DIR"/wp-tests-config.php | ||
| fi | ||
|
|
||
| } | ||
|
|
||
| install_db() { | ||
|
|
||
| if [ ${SKIP_DB_CREATE} = "true" ]; then | ||
| return 0 | ||
| fi | ||
|
|
||
| # parse DB_HOST for port or socket references | ||
| local PARTS=(${DB_HOST//\:/ }) | ||
| local DB_HOSTNAME=${PARTS[0]}; | ||
| local DB_SOCK_OR_PORT=${PARTS[1]}; | ||
| local EXTRA="" | ||
|
|
||
| if ! [ -z $DB_HOSTNAME ] ; then | ||
| if [ $(echo $DB_SOCK_OR_PORT | grep -e '^[0-9]\{1,\}$') ]; then | ||
| EXTRA=" --host=$DB_HOSTNAME --port=$DB_SOCK_OR_PORT --protocol=tcp" | ||
| elif ! [ -z $DB_SOCK_OR_PORT ] ; then | ||
| EXTRA=" --socket=$DB_SOCK_OR_PORT" | ||
| elif ! [ -z $DB_HOSTNAME ] ; then | ||
| EXTRA=" --host=$DB_HOSTNAME --protocol=tcp" | ||
| fi | ||
| fi | ||
|
|
||
| # create database | ||
| mysqladmin create $DB_NAME --user="$DB_USER" --password="$DB_PASS"$EXTRA | ||
| } | ||
|
|
||
| install_wp | ||
| install_test_suite | ||
| install_db |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <?xml version="1.0"?> | ||
| <ruleset name="WordPress Coding Standards for Plugins"> | ||
| <description>Generally-applicable sniffs for WordPress plugins</description> | ||
|
|
||
| <rule ref="WordPress-Core" /> | ||
| <rule ref="WordPress-Docs" /> | ||
|
|
||
| <exclude-pattern>*/node_modules/*</exclude-pattern> | ||
| <exclude-pattern>*/vendor/*</exclude-pattern> | ||
| </ruleset> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <phpunit | ||
| bootstrap="tests/bootstrap.php" | ||
| backupGlobals="false" | ||
| colors="true" | ||
| convertErrorsToExceptions="true" | ||
| convertNoticesToExceptions="true" | ||
| convertWarningsToExceptions="true" | ||
| > | ||
| <testsuites> | ||
| <testsuite> | ||
| <directory prefix="test-" suffix=".php">./tests/</directory> | ||
| </testsuite> | ||
| </testsuites> | ||
| <filter> | ||
| <whitelist processUncoveredFilesFromWhitelist="false" > | ||
| <file>exoskeleton.php</file> | ||
| <file>classes/class-exoskeleton.php</file> | ||
| </whitelist> | ||
| </filter> | ||
| <php> | ||
| <const name="PHPUNIT_EXOSKELETON_TESTING" value="true"/> | ||
| </php> | ||
| </phpunit> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <?php | ||
| /** | ||
| * PHPUnit bootstrap file | ||
| * | ||
| * @package Exoskeleton | ||
| */ | ||
|
|
||
| $_tests_dir = getenv( 'WP_TESTS_DIR' ); | ||
| if ( ! $_tests_dir ) { | ||
| $_tests_dir = dirname( __FILE__ ) . '/../../../../wordpress-tests-lib'; | ||
| } | ||
|
|
||
| // Give access to tests_add_filter() function. | ||
| require_once $_tests_dir . '/includes/functions.php'; | ||
|
|
||
| /** | ||
| * Manually load the plugin being tested. | ||
| */ | ||
| function _manually_load_plugin() { | ||
| require dirname( dirname( __FILE__ ) ) . '/exoskeleton.php'; | ||
| } | ||
| tests_add_filter( 'muplugins_loaded', '_manually_load_plugin' ); | ||
|
|
||
| // Start up the WP testing environment. | ||
| require $_tests_dir . '/includes/bootstrap.php'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to calculate the retry after headers in a different function that would be easier to test? Then we could just output the headers and exit here without altering any logic for tests.