feat(ci): package integrations into GitHub releases - #441
feat(ci): package integrations into GitHub releases#441Shubhank-Jonnada wants to merge 3 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25fea78009
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| run-name: Package integrations (${{ inputs.request_id || github.run_id }}) | ||
|
|
||
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
With this unguarded workflow_dispatch trigger, a write user can manually run the workflow from a non-default branch; GitHub's manual-run docs explicitly include a Branch dropdown for these runs. The job then checks out that selected ref and creates a release at its $GITHUB_SHA while using --skip-validate, so it can publish deployable packages from unmerged code instead of the already-merged/default-branch integrations described in CONTRIBUTING.md:316-319. Add a job/step guard for github.ref_name == github.event.repository.default_branch (or check out the default branch explicitly) before packaging and releasing.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Good catch. The release job now runs only when the selected ref is the repository default branch, so branch-selected dispatches stop before checkout, packaging, or release creation. The workflow guard was validated locally.
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Closes #440
Depends on Autohive-AI/autohive-integrations-tooling#62 and the HiveUp
2.5.0tag created after that PR merges.Summary
Security
contents: write; it has no Autohive URL or credential2.5.0, so no additional checkout secret is requiredTesting
release-plan --selection allresolved 99 integrationsSetup
Merge the tooling PR, publish immutable tag
2.5.0, then merge this PR. No additional repository token is required.