Skip to content

fix: skip score for workflows unexpected situations#92

Merged
amandazhuyilan merged 1 commit into
mainfrom
fix-deal-with-missing-workflow-row
Jun 26, 2026
Merged

fix: skip score for workflows unexpected situations#92
amandazhuyilan merged 1 commit into
mainfrom
fix-deal-with-missing-workflow-row

Conversation

@amandazhuyilan

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Fix score for runs without a workflow (due to previous database schema missing the workflow field)

Changes

job_utils.py catches the ValueError from get_output_spec, logs a warning, and returns None for that run's score instead of crashing.
Score is best-effort metadata and shouldn't be able to 500 the page. All other jobs will now render; the orphaned run will appear without a score.

How to Test

CI Tests shall pass

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added or updated documentation where necessary
  • I have run linting and unit tests locally
  • The code follows the project's style guidelines

@amandazhuyilan amandazhuyilan requested a review from vtnphan June 26, 2026 05:05

@vtnphan vtnphan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice short term fix! Liftoff

@amandazhuyilan amandazhuyilan merged commit 79d5a9b into main Jun 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants