Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
SBP-250 Replace Seqera Platform dataset uploads with direct S3 uploads for workflow samplesheets. This removes the dependency on Seqera datasets as an intermediary and simplifies the data flow: CSV samplesheets are now uploaded directly to S3, and the resulting S3 key is passed to workflow launchers.
Changes
seqera_dataset_idcolumn from theWorkflowRunmodel and added an Alembic migration (drop_seqera_dataset_id_from_workflow_runs) to drop it from the DBcreate_seqera_dataset,upload_dataset_to_seqera,upload_interaction_screening_dataset) with S3-backed equivalents (upload_csv_to_s3,upload_interaction_screening_csv_to_s3) inapp/services/datasets.pyWorkflowLaunchPayload.datasetId→s3InputKey; all three workflow executors (bindflow, wisps, proteinfold) now receives3_input_key: strinstead ofdataset_idDatasetUploadResponse/InteractionScreeningDatasetUploadResponse→S3DatasetUploadResponse/InteractionScreeningS3UploadResponseRunInputtracking: on workflow launch, the samplesheet S3 object is recorded as aRunInputlinked to theWorkflowRun, enabling a new presigned-URL endpoint to download the input samplesheetHow to Test
uv run alembic upgrade heads3InputKeyin the payload and confirm it succeedsdatasetIdpayloads are rejected with 422uv run pytest --cov=app --cov-fail-under=90uv run ruff check app tests && uv run black --check app tests && uv run mypy appType of change
Checklist