feat: update reporting process for qc reads and assembly pipelines#28
Draft
emilylm wants to merge 26 commits into
Draft
feat: update reporting process for qc reads and assembly pipelines#28emilylm wants to merge 26 commits into
emilylm wants to merge 26 commits into
Conversation
8c91fe3 to
c35022c
Compare
…ivalent check on ont or hi-c
…in taxon_info/bulk-insert
c35022c to
4e6d791
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR updates the assembly reporting workflow to better match the current assembly pipeline process.
It introduces explicit
assembly_runrecords for repo/commit-scoped pipeline invocations, links stage results to those runs, adds assembly-scoped QC read reporting, removes assembly-level status tracking, and aligns the QC-read model with the latest reporting contract by storingsource_read_file_checksumsand validating them against the experiment resolved frombpa_package_id.🔄 Type of Change
🧩 Key Changes
assembly_runas the explicit pipeline invocation model (assembly_id + github_repo + git_commit) and linkedassembly_stage_runrecords toassembly_run_idinstead of directly toassembly_id.POST /api/v1/assemblies/{assembly_id}/qc-reads/report, includingqc_read_assembly,source_read_file_checksums, updated QC file classification, and ENA prepared payload generation.assembly.status, updated manifest retrieval behaviour, added forward migrations for the schema changes, and updated docs/tests/Postman examples to match the new API shape.✅ Checklist
🔍 Review Notes
/assemblies/{assembly_id}/runs/{run_id}/stage-runsassembly.statushas been removedsource_read_file_checksumsrather than source BPA resource IDs0003_assembly_run_github0004_qc_reads_assembly_refs0005_remove_assembly_statusbpa_package_idresolves to an existing experimentsource_read_file_checksumsvalue matches aread.file_checksumfor that experiment📎 Related Issues / Tickets