Skip to content

refactor: complete Tier A+B API surface cleanup - #163

Merged
AustinKelsay merged 3 commits into
stagingfrom
feature/cleanup-tier-ab-api-surface
Jul 28, 2026
Merged

refactor: complete Tier A+B API surface cleanup#163
AustinKelsay merged 3 commits into
stagingfrom
feature/cleanup-tier-ab-api-surface

Conversation

@AustinKelsay

Copy link
Copy Markdown
Owner

Summary

Test plan

  • npx tsc --noEmit -p tsconfig.json
  • npm run lint
  • npm test -- --runInBand (1076 passed)
  • focused NIP-46 validator + NIP-57 client + web-exports suites
  • npm run build && npm run pack:verify && npm run commands:verify && npm run package-manager:verify
  • standards/spec code-review vs staging; worthy findings fixed
  • hosted CI on this PR
  • @coderabbit full review (local CLI silent → fallback review recorded)

Local CodeRabbit / fallback

Local coderabbit review --agent --type all --base staging produced no output after >4 minutes and was terminated. Fallback standards/spec review findings were addressed before push (NIP-42 README accuracy, NIP-46 README API block, curve-order Security changelog, SimpleNIP46 wording, examples demo note).

Known risks / out of scope

  • Compatibility Alias removals deferred to next major (ADR 0003).
  • Tier C god-module splits (relay.ts / nostr.ts / NIP-47 facades) out of scope.
  • Remaining NIP-46 boolean helpers (validateRequestPayload, etc.) keep legacy names; colliding security-validator names were the rename target.
  • Production release/promotion out of scope.

Made with Cursor

Close the remaining high-impact maintenance surface from the staging audit: publish the 1.0 Compatibility Alias kill-list, archive agent run dumps, document NIP-42, deprecate dual Zap/Simple facades toward canonical Public Facades, align NIP-46 validators with canonical key checks, and replace root type star-exports with explicit allowlists.

Closes #156
Closes #157
Closes #158
Closes #159
Closes #160
Closes #161
Closes #162
Part of #154

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 28, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@AustinKelsay

Copy link
Copy Markdown
Owner Author

@CodeRabbit full review

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0fa6d933-4320-42bf-a26b-86c63ff387d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/cleanup-tier-ab-api-surface

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

Co-authored-by: Cursor <cursoragent@cursor.com>
@AustinKelsay

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Clarify validateAuthEvent throw semantics, remove unexported throwing helpers from the NIP-46 public API reference, and drop the obsolete NIP46Validator test inventory label.

Co-authored-by: Cursor <cursoragent@cursor.com>
@AustinKelsay
AustinKelsay merged commit 133506b into staging Jul 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant