refactor: complete Tier A+B API surface cleanup - #163
Conversation
Close the remaining high-impact maintenance surface from the staging audit: publish the 1.0 Compatibility Alias kill-list, archive agent run dumps, document NIP-42, deprecate dual Zap/Simple facades toward canonical Public Facades, align NIP-46 validators with canonical key checks, and replace root type star-exports with explicit allowlists. Closes #156 Closes #157 Closes #158 Closes #159 Closes #160 Closes #161 Closes #162 Part of #154 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
@CodeRabbit full review |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Action performedFull review finished. |
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
Clarify validateAuthEvent throw semantics, remove unexported throwing helpers from the NIP-46 public API reference, and drop the obsolete NIP46Validator test inventory label. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Test plan
npx tsc --noEmit -p tsconfig.jsonnpm run lintnpm test -- --runInBand(1076 passed)npm run build && npm run pack:verify && npm run commands:verify && npm run package-manager:verify@coderabbit full review(local CLI silent → fallback review recorded)Local CodeRabbit / fallback
Local
coderabbit review --agent --type all --base stagingproduced no output after >4 minutes and was terminated. Fallback standards/spec review findings were addressed before push (NIP-42 README accuracy, NIP-46 README API block, curve-order Security changelog, SimpleNIP46 wording, examples demo note).Known risks / out of scope
relay.ts/nostr.ts/ NIP-47 facades) out of scope.validateRequestPayload, etc.) keep legacy names; colliding security-validator names were the rename target.Made with Cursor