feat(tui): add /tools so built-in capabilities are discoverable - #74
Merged
Conversation
Closes #71. A user asked the agent to create a folder, searched /skills for "filesystem", found nothing, and concluded the agent could not touch files. Two things made that unavoidable: there was no command listing the tool surface at all, and the twelve filesystem tools are named os.fs.*, so the word "filesystem" matches nothing even in a working listing. - /tools lists all 63 built-in tools grouped by family, stating plainly that they are always available and separate from /skills - /tools <query> filters by alias, family prefix or substring; aliases cover the words users actually type (filesystem, files, shell, terminal, web, network, images), and a miss says so and points at /tools and /skills instead of returning nothing - the Skills panel footer now carries "built-in tools: /tools" Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review follow-ups for the /tools listing: - /tools now runs DEFAULT_TOOL_DESCRIPTORS through the same filterToolDescriptorsByConfig gates bootstrap.ts applies, so a user with browser.enabled=false no longer sees browser.* advertised as available. Vision uses vision.enabled alone (the mmproj probe is not visible from the TUI listing) and the MCP gate uses the configured server list instead of live connections; both approximations follow the user's stated config. - The "git" alias pointed at os.shell, which hid all six os.git.* tools; it now resolves to os.git. - A query that only matches config-disabled tools says they are turned off in config instead of pretending they do not exist. - Single-segment tools (reply, finish) no longer render as "reply reply" in the overview. - The overview header says "enabled under the current config" instead of "always available, no install needed", and drops the em-dash. - searchTools drops a redundant toLowerCase; the grep test asserts toContain instead of toEqual so new grep-like tools do not break it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71.
Why
A user asked the agent to create a folder on the desktop, searched
/skillsfor "filesystem", found nothing, and concluded the agent could not touch files. The capability was never missing: theos.fs.*tools carry the frequent tier and sit in the prompt on every turn. Only their discoverability was.Two things made the dead end unavoidable:
/skills,/model,/memory,/mcpand others, but nothing for tools, so/skillswas the only place to look and by design never contains them.os.fs.read,os.fs.write,os.fs.list. The word appears in no tool name, so even a working listing would have returned nothing for that query.Change
/toolslists all built-in tools grouped by family (browser,os.fs,os.shell,os.web,memory.*,os.git,tasks, …), with a pointer to/skillsfor optional packs./tools <query>filters by alias, family prefix or substring. Aliases map the words users actually type onto the namespaces that exist:filesystem/files/disktoos.fs,terminal/bashtoos.shell,networktoos.http,imagestovision, and so on. A miss says so explicitly and offers the next step rather than returning an empty result./toolsdoes not print the static descriptor catalog. The listing runs through the samefilterToolDescriptorsByConfiggates the runtime applies inbootstrap.ts, so families disabled in config (browser.enabled=false,web.search.enabled=false,memory.*,tasks.agentToolsEnabled, MCP with no servers configured) do not show up as available. Two gates are approximated from config because their runtime inputs are probed at bootstrap: vision usesvision.enabledalone, and the MCP gate uses the configured server list rather than live connections. A query that only matches disabled tools says they are turned off in config instead of claiming no such tool exists. Thegitalias routes toos.git(an earlier revision pointed it atos.shell, which hid all sixos.git.*tools).built-in tools: /tools, so the dead end has an exit even for someone who never opens the palette.Testing
19 tests on the listing: family grouping and sort order, the coverage of families users ask about, the
filesystemalias resolving toos.fs.write(the exact query from the report), thegitalias resolving to theos.gitfamily, family-prefix and substring matching, case insensitivity, empty and unrelated queries, config gating (families disabled in config stay out, and a query that only matches disabled tools says they are turned off rather than nonexistent), and both render paths including the miss message.src/tui/commandsplussrc/runtime/filter-disabled-tools: 85 passing.tscclean. Fullsrc/tuirun shows the same pre-existing failures as main.