feat(tui): advertise chat scrolling in the footer - #72
Merged
Conversation
…crolling in the footer Two small UX changes decided by product: - the sidebar renders on the LEFT of the chat column, matching the desktop chat apps users already know. Only the JSX order and the divider side change: focus order, width, and the 100-column visibility threshold are untouched - the footer now advertises how to scroll the chat, which had no visible entry point: a platform-aware chip (fn+up on macOS, pgup elsewhere) in the idle chat footer and, more importantly, while a turn is streaming, which is exactly when scrolling back matters. The chip takes ctrl+b's slot to stay within the six-chip row; Observe remains reachable via /observe Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
fn+up/down on macOS, pgup/pgdn elsewhere, per product feedback. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The scroll-key test computed its expected value with the same process.platform expression as the component, so it could never fail. Both platform branches are now exercised via vi.resetModules plus a stubbed process.platform and a fresh dynamic import, against literal expected strings. Also add a case asserting the pending-approval footer (y/n/esc) carries no scroll chip, and update three comments and a test name that still said "right-rail" after the sidebar moved to the left. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ll hint Product decision after live testing: the rail move to the left did not hold up, so the layout goes back to exactly what it was before this branch. The sidebar renders after the chat column again and its single divider is back on its left edge. sidebar.tsx, tui-app.tsx, and tui-app.test.tsx are now byte-identical to their pre-branch state; the right-rail wording in docs, comments, and the smoke-test name is restored. The footer scroll chip (fn+up/down on macOS, pgup/pgdn elsewhere) and all hotkey-hint tests stay: that part of the change shipped as planned. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sosidudku1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat scrolling existed but had no visible entry point anywhere in the UI. This PR adds a platform-aware chip to the footer hint strip: "fn+up/down" on macOS (the spelling Mac users actually recognise for PageUp) and "pgup/pgdn" everywhere else.
The chip shows up in two places:
Tests: the scroll-key assertions use literal expected strings rather than re-deriving them from process.platform, so they can actually fail. Both platform spellings are exercised via a stubbed process.platform plus a fresh dynamic import, and a case asserts the pending-approval footer (y/n/esc) stays free of the chip.
The rail move that this PR originally carried was reverted after live testing; the rail stays on the right.