Changes to Get_Settler_Contaminants function in atContaminants.c - #70
Open
hmorzaria wants to merge 4 commits into
Open
Changes to Get_Settler_Contaminants function in atContaminants.c #70hmorzaria wants to merge 4 commits into
hmorzaria wants to merge 4 commits into
Conversation
… which was generated a segmentation fault when flagmaternaltransfer was set to 1
added 2 commits
July 24, 2026 16:39
…ge paths, also made change in atForceMovement.c that was still triggering segmentation fault
…stem-Model/AtlantisTrunk into maternal-transfer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
Describe the big picture of your changes here to communicate to the reviewers why they should accept this pull request.
Please describe the importance/impact of the problem and a description of how the changes in this pull request will address, resolve or improve the problem.
If it fixes a bug or resolves a feature request, be sure to link to the issue below.
Fixes issue #69 segmentation fault in flagmaternaltransfer
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that applyFurther comments
Identified a but when flagmaternaltransfer was turned on and all groups were turned on in the Puget Sound model (a previous run with a subset of groups had run), triggering a segmentation fault. Valgrind identified that the issue were multiple uninitialized values in atContaminants.c in function Get_Settler_Contaminants and in atmovement.c in function Ecology_Total_Verts_And_Migration.
Used Valgrind output to work through the errors, defined several variables and moved some of the code to earlier spots so the variables have values before going into the functions.