Skip to content

Changes to Get_Settler_Contaminants function in atContaminants.c - #70

Open
hmorzaria wants to merge 4 commits into
devfrom
maternal-transfer
Open

Changes to Get_Settler_Contaminants function in atContaminants.c #70
hmorzaria wants to merge 4 commits into
devfrom
maternal-transfer

Conversation

@hmorzaria

@hmorzaria hmorzaria commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Justification

Describe the big picture of your changes here to communicate to the reviewers why they should accept this pull request.
Please describe the importance/impact of the problem and a description of how the changes in this pull request will address, resolve or improve the problem.

If it fixes a bug or resolves a feature request, be sure to link to the issue below.
Fixes issue #69 segmentation fault in flagmaternaltransfer

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • [ X] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other change (if none of the other choices apply)

Further comments

Identified a but when flagmaternaltransfer was turned on and all groups were turned on in the Puget Sound model (a previous run with a subset of groups had run), triggering a segmentation fault. Valgrind identified that the issue were multiple uninitialized values in atContaminants.c in function Get_Settler_Contaminants and in atmovement.c in function Ecology_Total_Verts_And_Migration.
Used Valgrind output to work through the errors, defined several variables and moved some of the code to earlier spots so the variables have values before going into the functions.

  • [ X] I've created an issue
  • This is NA

… which was generated a segmentation fault when flagmaternaltransfer was set to 1
@hmorzaria
hmorzaria requested review from cecilieha and eafulton July 20, 2026 21:33
@hmorzaria hmorzaria added the bug Something isn't working label Jul 20, 2026
@github-project-automation github-project-automation Bot moved this to Pending issues in repos in Atlantis Ecosystem model development Jul 20, 2026
hmorzaria added 2 commits July 24, 2026 16:39
…ge paths, also made change in atForceMovement.c that was still triggering segmentation fault
@hmorzaria
hmorzaria changed the base branch from main to dev July 24, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Pending issues in repos

Development

Successfully merging this pull request may close these issues.

1 participant