fix: arguments arrays preservation on Launcher entrypoint - #69
Open
FarhanMS123 wants to merge 1 commit into
Open
fix: arguments arrays preservation on Launcher entrypoint#69FarhanMS123 wants to merge 1 commit into
FarhanMS123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I actually questioning why you really need this entrypoint with its complex args passing mechanism. My issue is cannot run this container with custom command where I need to mount to user data for persistent files. The original entrypoint is not allowed me to even use
/bin/bash -c "echo something > /tmp/test.txt"and just output empty while, with no file created, but exit 0.I assume this entrypoint would allow you (creator) to do some warm up to the system (by using entrypoint), while separate the application calling (using CMD), and let user to redefine textgen parameters (using env
EXTRA_LAUNCH_ARGS). So, here some proof of concept I done.I just make a simple
./launcher.shwithchmod +x.The objective:
Simple test:
./test.sh:I run:
Output:
I run:
Output: