Conversation
The downloaded ticket was missing its QR code. html-to-image captures a node by serializing the DOM/SVG tree; a <canvas>'s pixels are painted imperatively by JS and aren't part of that tree, so QRCodeCanvas's output could be missed or race the capture — a known limitation of DOM-to-image tools with canvas content. Swaps QRCodeCanvas for QRCodeSVG (both exported by the already-installed qrcode.react). An SVG element serializes natively as part of the node being captured, with no special-case pixel-copying or timing dependency. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downloaded ticket was missing its QR code. html-to-image captures a node by serializing the DOM/SVG tree; a 's pixels are painted imperatively by JS and aren't part of that tree, so QRCodeCanvas's output could be missed or race the capture — a known limitation of DOM-to-image tools with canvas content.
Swaps QRCodeCanvas for QRCodeSVG (both exported by the already-installed qrcode.react). An SVG element serializes natively as part of the node being captured, with no special-case pixel-copying or timing dependency.