Conversation
DialogHeader only renders its × button when passed its own onClose prop — separate from the Dialog wrapper's onClose, which only handles Escape and the native cancel event. The ticket dialog passed onClose to Dialog but not to DialogHeader, so it rendered with no visible way to dismiss it, discovered during manual Preview testing (no backdrop-click-to-close exists in this Dialog component at all, by design — every other dialog in this codebase that needs a close button passes onClose to both, e.g. ConfirmDialog.tsx:36, SettingsPanel.tsx:2023). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DialogHeader only renders its × button when passed its own onClose prop — separate from the Dialog wrapper's onClose, which only handles Escape and the native cancel event. The ticket dialog passed onClose to Dialog but not to DialogHeader, so it rendered with no visible way to dismiss it, discovered during manual Preview testing (no backdrop-click-to-close exists in this Dialog component at all, by design — every other dialog in this codebase that needs a close button passes onClose to both, e.g. ConfirmDialog.tsx:36, SettingsPanel.tsx:2023).