Make galaxy-table seeding deterministic across processes#16
Merged
Conversation
The per-table seed in _01a used hash((global_seed, 'table', table_index)), whose string element is hashed non-deterministically per process via PYTHONHASHSEED. This defeated the configured seed:42 reproducibility and made test_pipeline_run flaky: some CI runs drew a galaxy population with zero detectable lenses, so 01b wrote no detectable_gglenses_*.pkl and 02 raised FileNotFoundError. Use an all-integer tuple, matching 01b's process-stable pattern, so the draw is reproducible on every machine/run. The trailing 0 keeps table seeds distinct from 01b's run seeds. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-table seed in 01a used hash((global_seed, 'table', table_index)), whose string element is hashed non-deterministically per process via PYTHONHASHSEED. This defeated the configured seed:42 reproducibility and made test_pipeline_run flaky: some CI runs drew a galaxy population with zero detectable lenses, so 01b wrote no detectable_gglenses*.pkl and 02 raised FileNotFoundError.
Use an all-integer tuple, matching 01b's process-stable pattern, so the draw is reproducible on every machine/run. The trailing 0 keeps table seeds distinct from 01b's run seeds.