Skip to content

feat: add aster-forge-xml crate to replace xmltree #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AptS-1547 merged 4 commits into from
Jul 24, 2026
Merged

feat: add aster-forge-xml crate to replace xmltree #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
305ef17
feat: implement aster-forge-xml crate with quick-xml
yuanshi233 Jul 24, 2026
5e83eb4
refactor(aster_forge_xml): promote XML crate to standalone bounded pa…
AptS-1547 Jul 24, 2026
59648d4
ci(workflows): add XML fuzz harness build step
AptS-1547 Jul 24, 2026
0f755d6
ci(workflows): add nightly toolchain for fuzz target build
AptS-1547 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
- '**/*.rs'
- 'Cargo.toml'
- 'Cargo.lock'
- 'crates/aster_forge_xml/fuzz/Cargo.toml'

@coderabbitai coderabbitai Bot Jul 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

rg -n -C3 'paths:|aster_forge_xml|fuzz_targets' .github/workflows/rust.yml

Repository: AsterCommunity/AsterForge

Length of output: 988

别把 fuzz harness 源码变更漏网。

当前 paths 只覆盖 crates/aster_forge_xml/fuzz/Cargo.toml；像 crates/aster_forge_xml/fuzz/fuzz_targets/*.rs 这样的 harness 源码修改不会触发 CI。把 fuzz crate 的源文件/目录一起纳入 paths。

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/rust.yml at line 9, Update the Rust workflow’s paths
configuration to include the fuzz crate’s source directory and harness files,
including crates/aster_forge_xml/fuzz/fuzz_targets/*.rs, alongside its
Cargo.toml entry so harness changes trigger CI.

- 'templates/aster-service/**'
- 'scripts/coverage-summary.mjs'
- '.github/workflows/rust.yml'
Expand All @@ -15,6 +16,7 @@ on:
- '**/*.rs'
- 'Cargo.toml'
- 'Cargo.lock'
- 'crates/aster_forge_xml/fuzz/Cargo.toml'
- 'templates/aster-service/**'
- 'scripts/coverage-summary.mjs'
- '.github/workflows/rust.yml'
Expand Down Expand Up @@ -48,6 +50,12 @@ jobs:
- name: Build
run: cargo build --verbose

- name: Install nightly Rust toolchain for fuzzing
run: rustup toolchain install nightly --profile minimal

- name: Build XML fuzz harness
run: cargo +nightly build --manifest-path crates/aster_forge_xml/fuzz/Cargo.toml --bins

- name: Format check
run: cargo fmt --all -- --check

Expand Down
127 changes: 126 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ members = [
"crates/aster_forge_test",
"crates/aster_forge_utils",
"crates/aster_forge_validation",
"crates/aster_forge_xml",
]
resolver = "3"

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ All crate names use the `aster_forge_*` prefix. The workspace targets Rust `1.94
| Web and API | [`aster_forge_api`](https://forge.astercosm.com/crates/aster_forge_api), [`aster_forge_api_docs_macros`](https://forge.astercosm.com/crates/aster_forge_api_docs_macros), [`aster_forge_actix_middleware`](https://forge.astercosm.com/crates/aster_forge_actix_middleware), [`aster_forge_actix_observability`](https://forge.astercosm.com/crates/aster_forge_actix_observability), [`aster_forge_external_auth`](https://forge.astercosm.com/crates/aster_forge_external_auth) |
| Data, coordination, and background work | [`aster_forge_db`](https://forge.astercosm.com/crates/aster_forge_db), [`aster_forge_cache`](https://forge.astercosm.com/crates/aster_forge_cache), [`aster_forge_tasks`](https://forge.astercosm.com/crates/aster_forge_tasks), [`aster_forge_mail`](https://forge.astercosm.com/crates/aster_forge_mail), [`aster_forge_audit`](https://forge.astercosm.com/crates/aster_forge_audit) |
| Storage and domain-neutral helpers | [`aster_forge_storage_core`](https://forge.astercosm.com/crates/aster_forge_storage_core), [`aster_forge_file_classification`](https://forge.astercosm.com/crates/aster_forge_file_classification) |
| Utilities | [`aster_forge_crypto`](https://forge.astercosm.com/crates/aster_forge_crypto), [`aster_forge_utils`](https://forge.astercosm.com/crates/aster_forge_utils), [`aster_forge_validation`](https://forge.astercosm.com/crates/aster_forge_validation) |
| Utilities | [`aster_forge_crypto`](https://forge.astercosm.com/crates/aster_forge_crypto), [`aster_forge_utils`](https://forge.astercosm.com/crates/aster_forge_utils), [`aster_forge_validation`](https://forge.astercosm.com/crates/aster_forge_validation), [`aster_forge_xml`](https://forge.astercosm.com/crates/aster_forge_xml) |

## Integration rules

Expand Down
1 change: 0 additions & 1 deletion crates/aster_forge_utils/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ http.workspace = true
httpdate.workspace = true
ipnet.workspace = true
md-5.workspace = true
quick-xml.workspace = true
serde_json.workspace = true
thiserror.workspace = true
tokio = { workspace = true, features = ["fs", "time"] }
Expand Down
1 change: 0 additions & 1 deletion crates/aster_forge_utils/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ pub mod paths;
pub mod raii;
pub mod text;
pub mod url;
pub mod xml;

/// Result type returned by utility helpers.
pub type Result<T> = std::result::Result<T, UtilsError>;
Expand Down
Loading