Skip to content

Add Typer range validation to numeric CLI options #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexkroman merged 2 commits into from
Jun 8, 2026
Merged

Add Typer range validation to numeric CLI options #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da196ec
Add Typer range validation to numeric CLI options
claude Jun 8, 2026
a3f5d1a
Merge branch 'main' into claude/dependency-api-usage-05GF5
alexkroman Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions aai_cli/commands/stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ def stream(
None,
"--end-of-turn-confidence-threshold",
help="End-of-turn confidence (0-1).",
min=0.0,
max=1.0,
rich_help_panel=help_panels.OPT_TURNS,
),
min_turn_silence: int | None = typer.Option(
Expand All @@ -174,7 +176,9 @@ def stream(
vad_threshold: float | None = typer.Option(
None,
"--vad-threshold",
help="Voice-activity threshold.",
help="Voice-activity threshold (0-1).",
min=0.0,
max=1.0,
rich_help_panel=help_panels.OPT_TURNS,
),
format_turns: bool | None = typer.Option(
Expand All @@ -194,7 +198,11 @@ def stream(
None, "--speaker-labels", help="Label speakers.", rich_help_panel=help_panels.OPT_SPEAKERS
),
max_speakers: int | None = typer.Option(
None, "--max-speakers", help="Max speakers.", rich_help_panel=help_panels.OPT_SPEAKERS
None,
"--max-speakers",
help="Max speakers.",
min=1,
rich_help_panel=help_panels.OPT_SPEAKERS,
),
# features
voice_focus: NoiseSuppressionModel | None = typer.Option(
Expand All @@ -206,7 +214,9 @@ def stream(
voice_focus_threshold: float | None = typer.Option(
None,
"--voice-focus-threshold",
help="Voice-focus threshold.",
help="Voice-focus threshold (0-1).",
min=0.0,
max=1.0,
rich_help_panel=help_panels.OPT_FEATURES,
),
inactivity_timeout: int | None = typer.Option(
Expand Down
5 changes: 5 additions & 0 deletions aai_cli/commands/transcribe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ def transcribe(
None,
"--speakers-expected",
help="Hint speaker count.",
min=1,
rich_help_panel=help_panels.OPT_SPEAKERS,
),
multichannel: bool | None = typer.Option(
Expand Down Expand Up @@ -197,12 +198,16 @@ def transcribe(
None,
"--content-safety-confidence",
help="Content-safety confidence threshold (25-100).",
min=25,
max=100,
rich_help_panel=help_panels.OPT_GUARDRAILS,
),
speech_threshold: float | None = typer.Option(
None,
"--speech-threshold",
help="Minimum proportion of speech required (0-1).",
min=0.0,
max=1.0,
rich_help_panel=help_panels.OPT_GUARDRAILS,
),
# analysis
Expand Down
71 changes: 37 additions & 34 deletions tests/__snapshots__/test_cli_output_snapshots.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,26 +567,29 @@
│ (repeatable). │
╰──────────────────────────────────────────────────────────────────────────────╯
╭─ Turn Detection ─────────────────────────────────────────────────────────────╮
│ --end-of-turn-confid… FLOAT End-of-turn │
│ confidence (0-1). │
│ --min-turn-silence INTEGER Min silence to end a │
│ turn (ms). │
│ --max-turn-silence INTEGER Max silence before │
│ ending a turn (ms). │
│ --vad-threshold FLOAT Voice-activity │
│ threshold. │
│ --format-turns --no-format-turns Punctuate/format │
│ finalized turns. │
│ --include-partial-tu… Emit partial turns. │
│ --end-of-turn-co… FLOAT RANGE End-of-turn │
│ [0.0<=x<=1.0] confidence (0-1). │
│ --min-turn-silen… INTEGER Min silence to │
│ end a turn (ms). │
│ --max-turn-silen… INTEGER Max silence │
│ before ending a │
│ turn (ms). │
│ --vad-threshold FLOAT RANGE Voice-activity │
│ [0.0<=x<=1.0] threshold (0-1). │
│ --format-turns --no-format-tur… Punctuate/format │
│ finalized turns. │
│ --include-partia… Emit partial │
│ turns. │
╰──────────────────────────────────────────────────────────────────────────────╯
╭─ Speakers & Channels ────────────────────────────────────────────────────────╮
│ --speaker-labels Label speakers. │
│ --max-speakers INTEGER Max speakers. │
│ --speaker-labels Label speakers. │
│ --max-speakers INTEGER RANGE [x>=1] Max speakers. │
╰──────────────────────────────────────────────────────────────────────────────╯
╭─ Features ───────────────────────────────────────────────────────────────────╮
│ --voice-focus [near-field|far-field] Voice focus (noise │
│ suppression model). │
│ --voice-focus-thresho… FLOAT Voice-focus threshold. │
│ --voice-focus-thresho… FLOAT RANGE Voice-focus threshold │
│ [0.0<=x<=1.0] (0-1). │
│ --inactivity-timeout INTEGER Auto-close after N │
│ seconds idle. │
╰──────────────────────────────────────────────────────────────────────────────╯
Expand Down Expand Up @@ -681,28 +684,28 @@
│ --disfluencies Keep filler words (e.g. um, uh). │
╰──────────────────────────────────────────────────────────────────────────────╯
╭─ Speakers & Channels ────────────────────────────────────────────────────────╮
│ --speaker-labels Enable diarization. │
│ --speakers-expected INTEGER Hint speaker count. │
│ --multichannel Transcribe each audio channel │
│ separately. │
│ --speaker-labels Enable diarization. │
│ --speakers-expected INTEGER RANGE [x>=1] Hint speaker count. │
│ --multichannel Transcribe each audio │
│ channel separately. │
╰──────────────────────────────────────────────────────────────────────────────╯
╭─ Guardrails ─────────────────────────────────────────────────────────────────╮
│ --redact-pii Redact PII from the │
│ transcript. │
│ --redact-pii-policy TEXT Comma-separated PII │
│ policies (e.g. │
│ person_name,...). │
│ --redact-pii-sub [hash|entity_name] How to replace redacted │
│ PII. │
│ --redact-pii-audio Also redact audio. │
│ --filter-profanity Mask profanity. │
│ --content-safety Detect sensitive │
│ content. │
│ --content-safety-confid… INTEGER Content-safety │
│ confidence threshold │
│ (25-100). │
│ --speech-threshold FLOAT Minimum proportion of │
│ speech required (0-1). │
│ --redact-pii Redact PII from the │
│ transcript. │
│ --redact-pii-policy TEXT Comma-separated PII │
│ policies (e.g. │
│ person_name,...). │
│ --redact-pii-sub [hash|entity_name] How to replace │
│ redacted PII. │
│ --redact-pii-audio Also redact audio. │
│ --filter-profanity Mask profanity. │
│ --content-safety Detect sensitive │
│ content. │
│ --content-safety-conf… INTEGER RANGE Content-safety │
│ [25<=x<=100] confidence threshold │
│ (25-100). │
│ --speech-threshold FLOAT RANGE Minimum proportion of │
│ [0.0<=x<=1.0] speech required (0-1). │
╰──────────────────────────────────────────────────────────────────────────────╯
╭─ Analysis ───────────────────────────────────────────────────────────────────╮
│ --summarization Summarize the │
Expand Down
Loading