Fix: bwlimit/retries YAML and config keys were silently ignored (v3.11.1) - #5
Merged
Merged
Conversation
Both flags existed only on the CLI — a bwlimit or retries key in a jobs YAML or config file was silently ignored (same class of gap as the compress_where/from_stale mapping fixed in 3.10.0). Now wired into the batch YAML runner, the config loader and the job serializer; values pass through the existing strict validation. Version 3.11.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--bwlimitand--retriesexisted only as CLI flags — abwlimit/retrieskey in a jobs YAML or a config file was silently ignored (same gap class as thecompress_where/from_stalemapping fixed in 3.10.0). Now mapped in the batch YAML runner, config loader and job serializer.Testing
./build.sh --checkgreenbwlimit: bogusin a jobs YAML is rejected by the child's strict validation ("Invalid --bwlimit"), i.e. the key now reaches the job argv--bwlimit/--retriesbehavior unchanged (validated + used by scp/pv since 3.9.0)