Make StringEntry.localizations optional and improve decoding error reporting.#64
Open
maciej-bevel-health wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For better or worse Xcode can generate empty keys in the catalogue which look as follows:
Currently locheck will fail parsing a catalogue that contains such entry and, furthermore, displays an error message that isn't pointing to the issue:
error: Invalid file: Failed to parse string catalog: The data couldn’t be read because it is missing. (invalid_file)The change is to allow the
StringEntry.localizationsto be missing, so the catalogue parses.Furthermore I've changed the decoding error reporting to use the
errordirectly as this displays the specific decoding error.