fix: Correct Login issue#20
Merged
ArizonaGreenTea05 merged 2 commits intoJun 23, 2026
Merged
Conversation
added 2 commits
May 28, 2026 13:19
…tyName to fit the new response shape. SpondClient Login method was updated to use the NestedLoginTokenPropertyName if using the original LoginTokenPropertyName returned an Object from the response JSON.
ArizonaGreenTea05
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #19
The Login endpoint for v1 has been updated so all attempts to Login were returning a 404 message. On top of that the response from the Login endpoint now returns an object containing several tokens instead of the previous flat token.
Altered the ICommonData interface to include a NestedLoginTokenPropertyName to fit the new response shape.
SpondClient Login method was updated to use the NestedLoginTokenPropertyName if using the original LoginTokenPropertyName returned an Object from the response JSON.
Tested the changes by running the Spond.API.Test console app using my own live Spond email and password and was able to perform all the functions.