Stabilize onboarding cycle UX and enforce Python 3.10+ runtime gates - #69
Draft
AreteDriver wants to merge 11 commits into
Draft
Stabilize onboarding cycle UX and enforce Python 3.10+ runtime gates#69AreteDriver wants to merge 11 commits into
AreteDriver wants to merge 11 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request upgrades the project's minimum Python requirement to 3.10 and introduces several architectural and UX improvements. Key changes include the addition of a centralized CycleController for window management, an onboarding panel for the Overview tab, and enhanced character management with auto-discovery batching. Developer experience is also improved through pinned dependencies and pre-commit hooks. Review feedback suggests improving encapsulation in the CycleController by avoiding protected member access and refactoring the configuration directory resolution to prevent potential crashes in restricted environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR
Argus currently mixes UX improvements, runtime compatibility guardrails, and CI/tooling updates. This draft groups them so reviewers can validate end-to-end onboarding behavior and Python baseline enforcement in one pass.
Scope
Commit map
1927368onboarding/cycle workflow improvements.a60e321test/config fallback hardening.3129e1eAI tooling + changed-file quality gate.73db298docs/runtime baseline + CI typecheck alignment.e5a326fpre-Qt Python version guard.5ec22e6enforce Python floor inrun.shandinstall.sh.6eee4b0dev dependency conflict fix for fresh installs.d4e6377restore onboarding lifecycle, repair import signal wiring, and unblock lint/type gates.1b6d11dadd AI-gate Qt packages, repair the Pillow resampling test, and upgrade pytest/pytest-asyncio.Reviewer focus
Validation evidence
ruff check .: pass.ruff format --check .: 132 files formatted.mypy src/argus_overview --ignore-missing-imports --no-error-summary: pass locally and on GitHub.pip-audit --ignore-vuln CVE-2026-3219: no known vulnerabilities after upgrading pip in the validation environment.bash -n install.sh run.sh: pass.git diff --check: pass.1b6d11d: lint, format, mypy, secret scan, CodeQL, Truth Baseline, Linux package build, and normal security scan passed. Remaining failures were traced to missing AI-gate Qt packages, one stale Pillow assertion, andPYSEC-2026-1845on pytest 8.4.2;1b6d11daddresses exactly those causes.Risk and rollout
1b6d11dare green and one reviewer validates the onboarding flow.