Skip to content

fix(release): promote beta review remediation#320

Merged
gnanirahulnutakki merged 3 commits into
mainfrom
dev
Jul 23, 2026
Merged

fix(release): promote beta review remediation#320
gnanirahulnutakki merged 3 commits into
mainfrom
dev

Conversation

@gnanirahulnutakki

@gnanirahulnutakki gnanirahulnutakki commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

Promote only the beta review remediation landed by #319 from dev to main:

  • preserve Argo CD truncation evidence on the first emitted retained history fact;
  • align metrics and GitHub capability documentation with implemented boundaries;
  • normalize console CSS and correct stale or environment-specific session records;
  • retain GitSourceSnapshot and DesiredChange as pure contracts, with gitops.open-pr planned for P2 and GitHub-derived R2/R4 remediation evidence advisory-only.

Proven dev evidence

Release boundary

This PR does not create a tag, publish a release, change GHCR visibility, mutate a cluster, add credentials, or enable GitHub write execution. Those remain separate fail-closed release steps.

Refs #318

Summary by CodeRabbit

  • Bug Fixes

    • Corrected deployment history truncation markers so they appear on the first valid recorded observation.
  • Style & Accessibility

    • Improved console typography consistency and strengthened visually hidden content support.
  • Documentation

    • Clarified federation metrics, GitHub integration planning, testing instructions, and release review details.
    • Updated several session records to reflect completed work.

Gnani Rahul Nutakki and others added 3 commits July 23, 2026 15:01
Preserve Argo CD history-truncation evidence when the first retained entry is not emitted, and cover the edge case with a regression test.

Align release-facing metrics, GitOps, CSS, and session documentation with the implemented product boundary so beta artifacts do not overstate planned write execution or carry stale metadata.

Refs: #318
GSTACK-Checkpoint: 2026-07-23/beta5-review-remediation#1
Signed-off-by: Gnani Rahul Nutakki <gnani.nutakki@gmail.com>
Describe federation metrics as closed outcome-labeled series without identity dimensions, and scope the advisory-only restriction to GitHub-derived R2/R4 remediation evidence.

Record the follow-up review and fail-closed validation history without changing write authority or non-GitHub diagnostic confidence.

Refs: #318
GSTACK-Checkpoint: 2026-07-23/beta5-review-remediation#2
Signed-off-by: Gnani Rahul Nutakki <gnani.nutakki@gmail.com>
…view-findings

fix(release): remediate beta review findings
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 411e3d82-0b62-4153-a5a5-fbf0fe855946

📥 Commits

Reviewing files that changed from the base of the PR and between 8e30a6e and e83186f.

📒 Files selected for processing (12)
  • docs/SITH-NOTION.md
  • docs/specs/E2-readfed-brain-integrations.md
  • internal/connector/argocd/project.go
  • internal/connector/argocd/project_test.go
  • internal/hubserver/console_assets/console.css
  • sessions/2026-07-15-e10-loopback-metrics.md
  • sessions/2026-07-15-e10-process-audit-sink.md
  • sessions/2026-07-15-e8-browser-oidc-session.md
  • sessions/2026-07-16-brain-image-evidence.md
  • sessions/2026-07-16-fleetcache-workspace-scope.md
  • sessions/2026-07-21-deep-quality-audit.md
  • sessions/2026-07-23-beta5-review-remediation.md

📝 Walkthrough

Walkthrough

The PR updates federation and GitHub integration documentation, fixes Argo history truncation marking with regression coverage, normalizes console CSS declarations, and records session status, verification, and remediation updates.

Changes

Review remediation

Layer / File(s) Summary
Federation contract documentation
docs/SITH-NOTION.md, docs/specs/E2-readfed-brain-integrations.md
Federation metrics now use bounded request-time aggregates, while GitHub write planning and advisory evidence boundaries are clarified.
Argo history truncation projection
internal/connector/argocd/project.go, internal/connector/argocd/project_test.go
Truncation is marked on the first emitted history observation, including when earlier entries lack deployedAt, with regression coverage.
Console CSS normalization
internal/hubserver/console_assets/console.css
Mono font stacks, badge color keyword casing, and visually hidden clipping declarations are normalized.
Session status and verification records
sessions/*
Session completion statuses, standard make commands, scope wording, and beta remediation details are updated.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

  • Issue 318 — Covers the Argo truncation fix, aggregate metrics documentation, planned GitHub writes, CSS normalization, and session updates included in this PR.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately reflects the main change: promoting beta review remediation for release.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Comment @coderabbitai help to get the list of available commands.

@gnanirahulnutakki
gnanirahulnutakki merged commit c30dd4e into main Jul 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant