Skip to content

test: migrate showcase class fixtures for pytest 10#376

Merged
gnanirahulnutakki merged 1 commit into
devfrom
gnanirahulnutakki/issue-371-pytest-fixtures
Jul 23, 2026
Merged

test: migrate showcase class fixtures for pytest 10#376
gnanirahulnutakki merged 1 commit into
devfrom
gnanirahulnutakki/issue-371-pytest-fixtures

Conversation

@gnanirahulnutakki

Copy link
Copy Markdown
Member

Relevant issues

Closes #371

Type

  • feat — new capability or surface
  • fix — bug fix
  • docs — article, README, or doc change
  • refactor — internal change, no behaviour change
  • test — test-only change
  • ci — CI / workflow / tooling
  • chore — housekeeping
  • dev → main graduation — promoting reviewed work to release branch

Changes

Compatibility and proof boundary: this is test-only. It changes no runtime enforcement, network behavior, credentials, public claims, or production artifacts. The ten live-Ollama cases remain credential-gated and intentionally unverified by this local lane.

Testing

  • PYTHONPATH=. uv run --project . pytest tests/test_e2e_showcase.py tests/test_e2e_showcase_transcript.py -q --tb=short -W error::pytest.PytestRemovedIn10Warning — 29 passed, 10 skipped.
  • PYTHONPATH=. uv run --project . pytest tests/test_e2e_showcase.py -q --tb=short -W error::pytest.PytestRemovedIn10Warning — 18 passed, 10 skipped.
  • pytest collection — exactly 28 showcase cases.
  • Ruff 0.13.0 check and format check — passed.
  • uvx --from pre-commit==4.3.0 pre-commit run --files python/tests/test_e2e_showcase.py — all applicable hooks passed, including private-key and hardcoded-secret detection.
  • ./scripts/check-local.sh --quick — passed.
  • git diff --check — passed.

README and documentation were reviewed; no update is warranted for this internal test compatibility migration.

AI-assisted implementation and review were used. The human author reviewed the final diff, owns the commit, and retains accountability.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@gnanirahulnutakki, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 30071c97-b97d-4824-ade1-3d171f29aca0

📥 Commits

Reviewing files that changed from the base of the PR and between a5faae9 and 2140c9f.

📒 Files selected for processing (1)
  • python/tests/test_e2e_showcase.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gnanirahulnutakki/issue-371-pytest-fixtures

Comment @coderabbitai help to get the list of available commands.

Convert all seven class-scoped autouse showcase fixtures to pytest supported class methods so their setup remains class-wide after pytest 10 removes instance-method support.

Tests: 29 passed, 10 skipped with PytestRemovedIn10Warning promoted to an error.

Checkpoint: architect/sessions/release-v0.2.0-qualification/2026-07-22-journal.md
Signed-off-by: Gnani Rahul Nutakki <gnani.nutakki@gmail.com>
@gnanirahulnutakki
gnanirahulnutakki force-pushed the gnanirahulnutakki/issue-371-pytest-fixtures branch from 3712a4d to 2140c9f Compare July 23, 2026 05:21
@gnanirahulnutakki

Copy link
Copy Markdown
Member Author

Rebase and review checkpoint

dev advanced after the first green run through focused CodeQL fix a5faae9b1c713ab11765bcc201d637a9f7b067e9. This branch was rebased onto that exact tip and force-pushed only with --force-with-lease.

New signed/DCO head: 2140c9f8adb8e18ef1917650ab2ca2020efd31b3
Parent: a5faae9b1c713ab11765bcc201d637a9f7b067e9
Stable patch ID before/after rebase: 209a927d7f8dff5723385b8023fea46526749b70

The one-file patch is therefore identical to the committed-diff CodeRabbit CLI review that completed with zero findings before the rebase. Exact-head hosted CodeRabbit is rate-limited, so it is not being claimed as a substantive review.

Post-rebase local rerun:

  • targeted warning-as-error suite: 29 passed, 10 unchanged skips;
  • Ruff check/format: passed;
  • pre-commit 4.3.0 hooks including secret/private-key checks: passed.

Fresh exact-head GitHub CI is running and remains required before merge.

@gnanirahulnutakki
gnanirahulnutakki merged commit 8589d4b into dev Jul 23, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: migrate E2E showcase class fixtures before pytest 10

1 participant